Disable account #344
Disable account #344
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
==========================================
+ Coverage 78.30% 78.32% +0.01%
==========================================
Files 78 80 +2
Lines 5435 5467 +32
==========================================
+ Hits 4256 4282 +26
- Misses 1179 1185 +6 ☔ View full report in Codecov by Sentry. |
.vscode/settings.json
Outdated
| "python.testing.pytestArgs": ["tests"], | ||
| "python.testing.pytestArgs": [ | ||
| "." | ||
| ], | ||
| "python.testing.unittestEnabled": false, |
There was a problem hiding this comment.
Should this be changed?
app/endpoints/auth.py
Outdated
| if not user.enabled: | ||
| raise HTTPException( | ||
| status_code=status.HTTP_401_UNAUTHORIZED, | ||
| detail="Disabled account. Contact eclair@myecl.fr for more informations.", |
There was a problem hiding this comment.
Do we want to hard code an email in the API response?
app/endpoints/external_account.py
Outdated
| @router.get( | ||
| "/external/", | ||
| status_code=200, | ||
| tags=[Tags.external_account], | ||
| ) |
There was a problem hiding this comment.
I think we could put the endpoint in users.py
app/models/models_core.py
Outdated
| @@ -35,6 +35,7 @@ class CoreUser(Base): | |||
| phone: Mapped[str | None] = mapped_column(String) | |||
| floor: Mapped[FloorsType] = mapped_column(Enum(FloorsType), nullable=False) | |||
| created_on: Mapped[datetime | None] = mapped_column(DateTime(timezone=True)) | |||
| enabled: Mapped[bool] = mapped_column(Boolean, nullable=False) | |||
There was a problem hiding this comment.
What do you think of disabled?
Description
I created code to be able to delete accounts that do not have a Central address.
To do that, I :
I still have to exclude deactivated CoreUsers from the search