Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Users able to add and download duplicate podcast episodes to queue #2672

Closed
nichwall opened this issue Feb 27, 2024 · 3 comments · Fixed by #4041
Closed

[Bug]: Users able to add and download duplicate podcast episodes to queue #2672

nichwall opened this issue Feb 27, 2024 · 3 comments · Fixed by #4041
Labels
bug Something isn't working

Comments

@nichwall
Copy link
Contributor

Describe the issue

Users can mark the same episode for download multiple times using the "Find Episodes" modal. This adds the episode to the queue multiple times and results in duplicate files being downloaded and added to the podcast. A check against the queue before adding should be sufficient to fix this issue, or ensuring the queue has unique entries.

Download Queue:
Download queue

Podcast Episodes with library item ID in the filename:
Podcast episodes

Podcast Files
Podcast files

Steps to reproduce the issue

  1. Select a podcast episode to download using the "Find Episodes" modal
  2. Add one or more episodes to the download queue
  3. Open the "Find Episodes" modal again and select episodes add to the queue again

Audiobookshelf version

2.8.0

How are you running audiobookshelf?

Docker

@nichwall nichwall added the bug Something isn't working label Feb 27, 2024
@nichwall nichwall changed the title [Bug]: [Bug]: Users able to add and download duplicate podcast episodes to queue Feb 27, 2024
@nichwall
Copy link
Contributor Author

It is also possible to add episodes to the download queue if they finish downloading while the modal is open because the modal doesn't update on downloads, so adding to queue would also need to check if the episode already exists on the server. This may help with some other duplicate downloads issues that have been reported.

@RoyWolfe
Copy link

I'm running into a similar issue, probably for the same reason. I'm converting some youtube channels to audio-only to listen to. That conversion is not a fast process and since I have several channels I follow, ABS checks for new episodes again while the same files are still in the queue waiting to be downloaded, causing it to be added multiple times to the download queue.

Copy link

Fixed in v2.20.0.

@github-actions github-actions bot removed the awaiting release Issue is resolved and will be in the next release label Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants