Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use import type for importing type #922

Merged
merged 1 commit into from
May 4, 2023

Conversation

shahshahid81
Copy link
Contributor

@shahshahid81 shahshahid81 commented Mar 4, 2023

Proposed changes

This change won't give error when importsNotUsedAsValues is set to error in tsconfig.json and won't break existing code

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This change won't give error when `importsNotUsedAsValues` is set to `error` in tsconfig.json and won't break existing code
@stale
Copy link

stale bot commented May 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Abandoned Dropped and not into consideration label May 4, 2023
@Julien-R44
Copy link
Member

Oops. Sorry for taking so long. Thanks !

@stale stale bot removed the Status: Abandoned Dropped and not into consideration label May 4, 2023
@Julien-R44 Julien-R44 changed the base branch from master to develop May 4, 2023 09:08
@Julien-R44 Julien-R44 merged commit 8955b12 into adonisjs:develop May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants