Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: adonisjs/lucid
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v18.4.1
Choose a base ref
...
head repository: adonisjs/lucid
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v18.4.2
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Sep 26, 2023

  1. fix(configure): change localhost to 127.0.0.1 

    Closes adonisjs/core#4253
    @RomainLanz
    RomainLanz committed Sep 26, 2023
    Copy the full SHA
    0417d84 View commit details

  2. chore(release): 18.4.2

    @RomainLanz
    RomainLanz committed Sep 26, 2023
    Loading
    Loading status checks…
    Copy the full SHA
    dcd0dd8 View commit details
Showing with 6 additions and 6 deletions.
  1. +5 −5 instructions.ts
  2. +1 −1 package.json
10 changes: 5 additions & 5 deletions instructions.ts
View file
Original file line number Diff line number Diff line change
@@ -45,28 +45,28 @@ const DB_SERVER_PROMPT_CHOICES = [
const DB_SERVER_ENV_VALUES = {
sqlite: {},
mysql: {
MYSQL_HOST: 'localhost',
MYSQL_HOST: '127.0.0.1',
MYSQL_PORT: 3306,
MYSQL_USER: 'lucid',
MYSQL_PASSWORD: '',
MYSQL_DB_NAME: 'lucid',
},
pg: {
PG_HOST: 'localhost',
PG_HOST: '127.0.0.1',
PG_PORT: 5432,
PG_USER: 'lucid',
PG_PASSWORD: '',
PG_DB_NAME: 'lucid',
},
oracle: {
ORACLE_HOST: 'localhost',
ORACLE_HOST: '127.0.0.1',
ORACLE_PORT: 1521,
ORACLE_USER: 'lucid',
ORACLE_PASSWORD: '',
ORACLE_DB_NAME: 'lucid',
},
mssql: {
MSSQL_SERVER: 'localhost',
MSSQL_SERVER: '127.0.0.1',
MSSQL_PORT: 1433,
MSSQL_USER: 'lucid',
MSSQL_PASSWORD: '',
@@ -93,7 +93,7 @@ function getDbDrivers(sink: typeof sinkStatic) {
.getPrompt()
.multiple('Select the database driver you want to use', DB_SERVER_PROMPT_CHOICES, {
validate(choices) {
return choices && choices.length ? true : 'Select atleast one database driver to continue'
return choices && choices.length ? true : 'Select at least one database driver to continue'
},
})
}
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@adonisjs/lucid",
"version": "18.4.1",
"version": "18.4.2",
"description": "SQL ORM built on top of Active Record pattern",
"engines": {
"node": ">=14.15.4"