Fix virtualizer bug when an item changes parents #6723
Merged
+63
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw this issue in doc search due to section keys changing. Virtualizer saw the child keys as already visible even though their parents changed and didn't create new views for them. Now we treat parent key changes the same way we treat deletes. The view will then be re-created under its new parent. Added a test for this case when a listbox item changes sections.
In doc search we also make this more efficient by using only the title as the key rather than including the index, so that when sections are re-ordered the keys remain consistent and views can be reused.