Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: adobe/react-spectrum
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: react-stately@3.33.0
Choose a base ref
...
head repository: adobe/react-spectrum
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: react-stately@3.34.0
Choose a head ref
29 contributors

Commits on Oct 1, 2024

  1. Release notes for S2 v0.4.0 (#7099)

    @devongovett
    devongovett authored Oct 1, 2024
    1
    Copy the full SHA
    7b6fc10 View commit details

  2. September v3 Release Notes (#7101)

    @yihuiliao
    yihuiliao authored Oct 1, 2024
    1
    Copy the full SHA
    44fa2a5 View commit details

  3. add Accordion breaking changes to release notes (#7128)

    @reidbarber
    reidbarber authored Oct 1, 2024
    Copy the full SHA
    f489e00 View commit details

  4. Add versions to release notes, and starter kit links to color picker … 

    …docs (#7129)
    @devongovett
    devongovett authored Oct 1, 2024
    1
    Copy the full SHA
    c01850b View commit details

  5. Rename Table -> TableView in S2 release notes (#7130)

    @devongovett
    devongovett authored Oct 1, 2024
    2
    Copy the full SHA
    4818630 View commit details

Commits on Oct 2, 2024

  1. Blog post: Accessible Color Descriptions for Improved Color Pickers (#… 

    …7124)
    @devongovett
    devongovett authored Oct 2, 2024
    Copy the full SHA
    920832d View commit details

  2. remove unused svg

    @devongovett
    devongovett committed Oct 2, 2024
    Copy the full SHA
    fc02d6e View commit details

  3. Bump browserslist resolution to 4.24 (#7137)

    @devongovett
    devongovett authored Oct 2, 2024
    2
    Copy the full SHA
    240c29b View commit details

Commits on Oct 3, 2024

  1. Fix Meter docs story so it renders with the proper width (#7140)

    @LFDanLu
    LFDanLu authored Oct 3, 2024
    1
    Copy the full SHA
    25f304d View commit details

Commits on Oct 8, 2024

  1. Temporary fix for S2 storybook crash when showing code in dark mode (#… 

    …7135)
    @LFDanLu
    LFDanLu authored Oct 8, 2024
    Copy the full SHA
    df6e3c0 View commit details

  2. Expand dependency version support in Icon Transformer (#7133) 

    * Expand dependency version support in Icon Transformer

* add test for icon builder to verdaccio build

* fix the range for the builder since we're pre-release

* fix yarn lock

* update verdaccio script to handle packages which are in pre-release without a major version

* update yarn lock

* turn off verdaccio again

* turn back on verdaccio

* turn verdaccio back off

* Fix parcel plugin version

---------

Co-authored-by: Devon Govett <devongovett@gmail.com>
    @snowystinger @devongovett
    snowystinger and devongovett authored Oct 8, 2024
    1
    Copy the full SHA
    139a72d View commit details

  3. Publish

    @devongovett
    devongovett committed Oct 8, 2024
    Copy the full SHA
    03cfde2 View commit details

  4. Update yarn.lock

    @devongovett
    devongovett committed Oct 8, 2024
    2
    Copy the full SHA
    533a02f View commit details

Commits on Oct 9, 2024

  1. add @storybook/addon-a11y to S2 storybook (#7068) 

    * add @storybook/addon-a11y to s2 storybook

* update yarn.lock

* fix a11y issues in stories

* add @storybook/addon-a11y to s2 storybook

* update yarn.lock

* fix a11y issues in stories

---------

Co-authored-by: Daniel Lu <dl1644@gmail.com>
    @reidbarber @LFDanLu
    reidbarber and LFDanLu authored Oct 9, 2024
    1
    Copy the full SHA
    bebc976 View commit details

Commits on Oct 10, 2024

  1. Add missing slot contexts and forwardRefs to CardView and TableView (#… 

    …7161)

* Add missing slot contexts to CardView and TableView

* add forwardRef to Table sub components
    @LFDanLu
    LFDanLu authored Oct 10, 2024
    1
    Copy the full SHA
    454da05 View commit details

  2. TypeScript plugin to add macro import attribute to auto imports (#7141) 

    * TypeScript plugin to add macro import attribute to auto imports

* fix lockfile
    @devongovett
    devongovett authored Oct 10, 2024
    1
    Copy the full SHA
    8a7cb15 View commit details

  3. fix tanstack router useHref example (#7148)

    @kveperedo
    kveperedo authored Oct 10, 2024
    1
    Copy the full SHA
    e9aa00a View commit details

  4. fix: [RAC] Checkbox applies data attributes to both the input and the… 

    … label (#7151)

* applies data attributes to label (not input)

* not to propagate the data attributes to inputProps
    @syd03098
    syd03098 authored Oct 10, 2024
    1
    Copy the full SHA
    0c28454 View commit details

  5. fix(s2): ensure slider respects custom widths and correct the fillOff… 

    …set (#7138)

* fix(s2): ensure slider respects custom widths and correct fillOffset

* remove fieldInput from track styling

* add chromatic story replicating issue

* fix lint
    @yihuiliao
    yihuiliao authored Oct 10, 2024
    1
    Copy the full SHA
    a45e2a5 View commit details

Commits on Oct 11, 2024

  1. feat: support label position side in meter (#7180)

    @yihuiliao
    yihuiliao authored Oct 11, 2024
    1
    Copy the full SHA
    db60bab View commit details

Commits on Oct 14, 2024

  1. Fix usePress so it doesnt preventDefault when taps happen on non plai… 

    …n text content (#7190)
    @LFDanLu
    LFDanLu authored Oct 14, 2024
    1
    Copy the full SHA
    c42990f View commit details

  2. Publish

    @devongovett
    devongovett committed Oct 14, 2024
    1
    Copy the full SHA
    f0245fd View commit details

Commits on Oct 15, 2024

  1. Update table resizer svg and bump tokens package (#7154) 

    * Update resizer svg to newest one from icons team

* Bump tokens package

* update Badge colors

* update to use the same token names instead of their underlying color

* replacing accent with informative
    @LFDanLu
    LFDanLu authored Oct 15, 2024
    1
    Copy the full SHA
    987f174 View commit details

  2. Add expanded boolean attribute to tailwind plugin (#7152) 

    * Add expanded boolean attribute to tailwind plugin

After testing out the new `Disclosure` components, I see that the tailwind plugin does not support styling the `expanded` state, leaving me to style using `data-[expanded]`. This PR adds `expanded` top the list of boolean states.

* Update tests

* fix tests

* fix test

* Add selector for native variant

* lint fix
    @neefrehman
    neefrehman authored Oct 15, 2024
    1
    Copy the full SHA
    e22e960 View commit details

  3. fix: add Checkbox default slot to GridList and Table (#7188) 

    * Fix Checkbox default slot

* fix lint
    @snowystinger
    snowystinger authored Oct 15, 2024
    1
    Copy the full SHA
    f77152e View commit details

  4. Fix NumberParser getSymbols rounding support (#7186)

    @snowystinger
    snowystinger authored Oct 15, 2024
    1
    Copy the full SHA
    f459c18 View commit details

  5. Decrease timeouts in test utils (#7102) 

    * Decrease chance of hitting timeouts on table tests

* move throw outside of act

* fix TS
    @snowystinger
    snowystinger authored Oct 15, 2024
    1
    Copy the full SHA
    7a9c220 View commit details

  6. feat: Lint pr titles (#6770) 

    * initialize github actions

* update linting code

* update comment

* update wip regex

* add link to pr naming guide

* cache yarn?

* update frozen-lockfile to immutable for yarn 4

* try caching node modules

* remove hardened mode, testing to see yarn install time

* remove action, use workflow only
    @yihuiliao
    yihuiliao authored Oct 15, 2024
    1
    Copy the full SHA
    ce87249 View commit details

  7. Mask the contents of a scrolled row for a quiet table (#7193) 

    cant use transparent for the default quiet row state, need a opaque color to hide scrolled text
    @LFDanLu
    LFDanLu authored Oct 15, 2024
    Copy the full SHA
    0d0e21b View commit details

  8. docs: add contributing Q & A section (#6951) 

    * docs: add contributing Q & A section

* Update CONTRIBUTING.md

Try without specifying language

* Apply suggestions from code review

Co-authored-by: Robert Snow <snowystinger@gmail.com>

---------

Co-authored-by: Reid Barber <reid@reidbarber.com>
Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
Co-authored-by: Robert Snow <snowystinger@gmail.com>
    @unional @reidbarber
    @yihuiliao @snowystinger
    4 people authored Oct 15, 2024
    1
    Copy the full SHA
    06cdad7 View commit details

  9. fix: ensure Dialog has the data-rac attribute (#7189) 

    * Ensure `Dialog` has the `data-rac` attribute

* cleanup
    @amitdahan
    amitdahan authored Oct 15, 2024
    1
    Copy the full SHA
    9152d83 View commit details

Commits on Oct 16, 2024

  1. Set default value for type parameter in SelectProps (#7014) 

    Co-authored-by: Reid Barber <reid@reidbarber.com>
    @kp047i @reidbarber
    kp047i and reidbarber authored Oct 16, 2024
    1
    Copy the full SHA
    e1b72a7 View commit details

Commits on Oct 17, 2024

  1. feat(s2): update accordion api to allow sibling elements in disclosur… 

    …e header (#7179)

* update s2 accordion api

* fix lint

* rename to disclosure title, context for action button

* fix lint

* remove console log

* fix typscript

* allow disclosure title to wrap header

* add chromatic stories

* make code more concise

* fix lint

* fix chromatic stories

---------

Co-authored-by: Robert Snow <rsnow@adobe.com>
    @yihuiliao @snowystinger
    yihuiliao and snowystinger authored Oct 17, 2024
    1
    Copy the full SHA
    b958085 View commit details

Commits on Oct 18, 2024

  1. docs: Disclosure hook docs (#7178) 

    * docs: disclosure hooks

* docs types

* move DisclosureGroup to useDisclosureGroupState docs page

* add anatomy diagram from #7165 to useDisclosure docs

* expand on hidden="until-found"

* fix interface tables

* Revert "move DisclosureGroup to useDisclosureGroupState docs page"

This reverts commit 8216354.
    @reidbarber
    reidbarber authored Oct 18, 2024
    1
    Copy the full SHA
    72a85cc View commit details

  2. docs(RAC): add tailwind starter for Disclosure and DisclosureGroup (#… 

    …7166)

* add tailwind starter for Disclosure and DisclosureGroup

* fix focus ring border radius

* update disabled chevron style

* fix focus ring in group

* cleanup variants and styles

* fix text color

* fix padding

* move DisclosureGroup to it's own story

---------

Co-authored-by: Robert Snow <rsnow@adobe.com>
Co-authored-by: Daniel Lu <dl1644@gmail.com>
    @reidbarber @snowystinger @LFDanLu
    3 people authored Oct 18, 2024
    1
    Copy the full SHA
    69109f0 View commit details

  3. docs: update accordion, disclosure, disclosure group docs (#7165) 

    * initial accordion docs

* more v3 disclosure docs

* add rac disclosure and disclosure group docs

* add anatomy diagrams and example cards

* remove disclosure children to be required

* edits

* update wording

* edits

* add inline styles

* use heading, couple edits

* use title instead of label, add to advance customization section

* add example to disclosure group
    @yihuiliao
    yihuiliao authored Oct 18, 2024
    1
    Copy the full SHA
    18835f7 View commit details

  4. chore: Update linting (#7201) 

    * Update linting

* Update jest.config.js
    @snowystinger
    snowystinger authored Oct 18, 2024
    1
    Copy the full SHA
    0ddbe6f View commit details

Commits on Oct 21, 2024

  1. fix: Support hidden="until-found" in DisclosureGroup (#7199) 

    * support hidden="until-found" in DisclosureGroup

* typescript

* cleanup

* useLayoutEffect and RAF

* add RAF/flushSync

* lint

* add comments

* remove extra changes from merge

* revert newlines

* typescript

* more typescript

* use DisclosureTitle
    @reidbarber
    reidbarber authored Oct 21, 2024
    1
    Copy the full SHA
    b887497 View commit details

  2. fix: Accordion/Disclosure release prep (#7216) 

    * RAC Disclosure SSR tests

* tests for nested disclosures and interactive adjacent elements

* DisclosurePanel: add DOMProps and render props type/table

* update v3 stories and chromatic

* update v3 Accordion deps

* add v3 Accordion SSR test

* update DisclosureGroupProps type to remove collection in jsdoc

* more v3 accordion tests

* yarn.lock

* lint

* add isQuiet to v3 Accordion/Disclosure

* add focus ring style

* update stories/chromatic

* lint

* remove active outline

* lint

* add isQuiet to v3 docs
    @reidbarber
    reidbarber authored Oct 21, 2024
    1
    Copy the full SHA
    4f85a35 View commit details

Commits on Oct 22, 2024

  1. fix(examples): s2 dialog's weren't closing (#7219)

    @ktabors
    ktabors authored Oct 22, 2024
    1
    Copy the full SHA
    a56a735 View commit details

Commits on Oct 23, 2024

  1. chore: eslint speed up (#7222) 

    * fix: eslint speed up

* use the kindly published fixed version
    @snowystinger
    snowystinger authored Oct 23, 2024
    1
    Copy the full SHA
    cbac9c0 View commit details

  2. fix dialog codemod close function (#7233)

    @reidbarber
    reidbarber authored Oct 23, 2024
    1
    Copy the full SHA
    68e3057 View commit details

  3. fix useButton href condition (#7239)

    @mehm8128
    mehm8128 authored Oct 23, 2024
    1
    Copy the full SHA
    09dc3c0 View commit details

Commits on Oct 24, 2024

  1. fix: TS Strict aria C and D (#6761) 

    * TS Strict aria C and D

* Propagate input type from textfield to focusable props

* Check input key for null in useDateSegment before calling onInput

* review followup

* fix types

* review comments

* fix remaining ts error

* sort descriptor is required

* keep value required

---------

Co-authored-by: Devon Govett <devongovett@gmail.com>
    @snowystinger @devongovett
    snowystinger and devongovett authored Oct 24, 2024
    1
    Copy the full SHA
    fb28ab3 View commit details

  2. support pending in RAC tailwind plugin (#7231)

    @reidbarber
    reidbarber authored Oct 24, 2024
    1
    Copy the full SHA
    37fbf02 View commit details

  3. feat: Reusable tests (#7011) 

    * Reusable tests

* Add more tests

* Fixing lint

* fix lint and types

* Fix tests for s2 with icons

* fix lint

* Add some submenu tests

* Add tests for RSPv3 since that's where I'm moving from

* fix types and lint

* fix lock file

* Fix React 16&17 tests

* Remove duplicates, improve menu utility, allow tester overrides, add more interaction types

* fix 17 tests

* fix lint

* removed some dead code

* Fix merge conflicts

* remove unnecessary change

* update lock file

* fix lint
    @snowystinger
    snowystinger authored Oct 24, 2024
    1
    Copy the full SHA
    cd313a3 View commit details

  4. RAC: Fix tooltip stuck on screen when scrolling (#7227) 

    This commit ports #6984 to
react-aria-components.

Co-authored-by: Robert Snow <rsnow@adobe.com>
    @acr92 @snowystinger
    acr92 and snowystinger authored Oct 24, 2024
    1
    Copy the full SHA
    93c26d8 View commit details

Commits on Oct 28, 2024

  1. fix tailwind starter submenu story (#7251)

    @reidbarber
    reidbarber authored Oct 28, 2024
    1
    Copy the full SHA
    e24ea2f View commit details

  2. fix: Accordion/Disclosure fixes from testing (#7218) 

    * remove UNSTABLE_ prefix

* add aria-hidden to collapsed disclosure panels

* add controlled example to s2 docs

* update S2 Accordion down state

* fix v3 styles (HCM, border-radius, hover when open)

* remove display: none in v3

* lint

* fix imports

* fix v3 focus/down styles

* ignore repeat keydown events

* fix acts

* switch onKeyDown to onPressStart

* add style props to v3 Disclosure,  DisclosurePanel, and DisclosureHeader

* fix bottom border on individual disclosures

* lint

* fix same disclosure border top issue in v3

* use default case

* release keydown event

* fix storybook code output

* fix v3 quiet HCM

* docs: follow-up on accordion docs from testing (#7232)

* docs: follow-up on accordion docs from testing

* updates svgs for mobile, follow up from reviews

* prevent outline on header on android

* fix examples in useDisclosure on mobile

* update focus visible

* add focusProps to disclosure group example

* use merge props

---------

Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
    @reidbarber @yihuiliao
    reidbarber and yihuiliao authored Oct 28, 2024
    Copy the full SHA
    6607108 View commit details

  3. Make sure there arent dupe stories between Disclosure and Accordion (#… 

    …7272)
    @LFDanLu
    LFDanLu authored Oct 28, 2024
    Copy the full SHA
    4baa1b0 View commit details
Showing 3,099 changed files with 77,118 additions and 18,902 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
4 changes: 3 additions & 1 deletion .circleci/config.yml
View file
Original file line number Diff line number Diff line change
@@ -290,7 +290,9 @@ jobs:

- run:
name: lint
command: yarn lint
command: |
yarn test:lint
yarn lint
ts-build-branch:
executor: rsp-large
19 changes: 0 additions & 19 deletions .eslintignore
View file

This file was deleted.

336 changes: 0 additions & 336 deletions .eslintrc.js
View file

This file was deleted.

25 changes: 25 additions & 0 deletions .github/workflows/lint-pr-titles.yaml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: PR Title Lint
on:
pull_request:
types: [opened, edited, reopened, synchronize]
permissions:
pull-requests: read
jobs:
pr-title-lint:
runs-on: ubuntu-latest
name: Lint PR Title
steps:
- name: Check PR Title
env:
TITLE: ${{ github.event.pull_request.title}}
run: |
if [[ "${TITLE,,}" =~ ^\[?\(?wip\]?\)? ]]; then
echo "PR is marked as a WIP. Skipping validation."
exit 0
elif (echo "${TITLE,,}" | grep -P "^(fix|feat|build|chore|docs|test|refactor|ci|localize|bump|revert)(\(([A-Za-z0-9])+\))?:"); then
echo "Success"
exit 0
else
echo "PR title validation failed. Please read our PR naming guide on our github wiki to see how to correctly name your PR: https://github.com/adobe/react-spectrum/wiki/Pull-Request-Naming-Guide"
exit 1
fi
Loading