-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Comparing changes
Open a pull request
base repository: adobe/react-spectrum
base: react-stately@3.25.0
head repository: adobe/react-spectrum
compare: react-stately@3.26.0
Commits on Aug 9, 2023
-
Move InlineAlert types into RSP (#4890)
No need for a separate @react-types/package
1Configuration menu - View commit details
-
Copy full SHA for cd601ff - Browse repository at this point
Copy the full SHA cd601ffView commit details -
Merge branch 'main' of github.com:adobe/react-spectrum
# Conflicts: # packages/@react-spectrum/inlinealert/package.json # packages/@react-types/inlinealert/package.json
Configuration menu - View commit details
-
Copy full SHA for 5dd5fcd - Browse repository at this point
Copy the full SHA 5dd5fcdView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for d4dfe4b - Browse repository at this point
Copy the full SHA d4dfe4bView commit details -
2
Configuration menu - View commit details
-
Copy full SHA for 0e35939 - Browse repository at this point
Copy the full SHA 0e35939View commit details
Commits on Aug 10, 2023
-
Removing aria-disabled so TalkBack users can open the context dialog (#…
…4710) * Removing aria-disabled so TalkBack users can double tap to open the context dialog * Updating aria-describedby label for unavailable menu items
1Configuration menu - View commit details
-
Copy full SHA for 66f9638 - Browse repository at this point
Copy the full SHA 66f9638View commit details -
RAC + Spectrum + Tailwind example (#4819)
* initialize example * add to verdaccio * typo * temporarily enable build comment * temp remove main filter * add readme * update config * add more examples * improve default focus ring * simplify examples * split out into preset * add font weights * add letterSpacing and lineHeight * add transition timings and durations * improve sentiment example * improve select box example * improve select box example * improve examples * add sizes * fix size values * fix transition values * update break points * improve examples * add dropShadow to preset * add Theme switcher * dark mode fixes * clean up * fix spacing/sizing * spacing * cleanup * add default blue * add opacity * fix theme switcher margin * add rac plugin * update sentiment example to style w/ attributes * add plugin to config * cleanup attributes in plugin * cleanup plugin * add more color variants * formatting * update README * cleanup * use custom selector for dark mode * revert CI changes * cleanup
1Configuration menu - View commit details
-
Copy full SHA for 1775ff2 - Browse repository at this point
Copy the full SHA 1775ff2View commit details -
Un-revert "fix(#4313): ariaHideOutside/aria-modal-polyfill: use inert…
1Configuration menu - View commit details
-
Copy full SHA for be50125 - Browse repository at this point
Copy the full SHA be50125View commit details
Commits on Aug 15, 2023
-
[RAC]: Update Tabs navigation for arrow keys (#4821)
Allow tab item select via all arrow keys regardless of orientation. Co-authored-by: Daniel Lu <dl1644@gmail.com>
1Configuration menu - View commit details
-
Copy full SHA for c6313b4 - Browse repository at this point
Copy the full SHA c6313b4View commit details
Commits on Aug 16, 2023
-
Add support for automated Storybook accessibility testing (#4820)
* quick convert to csf 3 * cleanup and disabling aria-hidden rule * adding storybook test runner * sample failures for test to catch * Revert "sample failures for test to catch" This reverts commit 36fa68a. * experimenting with interaction test * poking around to try and ignore aria rule for specific selector * test catching render errors and reuse play functions * using story axe config instead of manually setting it in main * fix lint and add keyboard interaction test * experiementing with jest-axe * testing interaction panel with simpler component * update yarn.lock * comments and cleanup * removing axe-core stuff this is a working commit before version bumping storybook interactions, for some reason it is breaking * disabling some false positives and run against all stories * fix storyName warning from storybook test runner * adding partial DnD interactions test * fixing yarn.lock after rebase * fixing package.json from rebase * update and cleanup tests + update to data test ids * fix/ignore various story only aXe issues (Card,Dialog, Landmark, DnD) some are fixed by adding ids/labels, other are ignored because they are story only tests cases and not part of the actual component accessibility * fix/ignore various story only aXe issues (ListBox, NumberField, Table, Toast, RAC) * fix/ignore various story only aXe issues (FocusScope, List, Checkbox, Meter, SideNav * fixing the rest of the failing false positive tests * fix lint
1Configuration menu - View commit details
-
Copy full SHA for 09a258f - Browse repository at this point
Copy the full SHA 09a258fView commit details
Commits on Aug 18, 2023
-
1
Configuration menu - View commit details
-
Copy full SHA for 0607fd9 - Browse repository at this point
Copy the full SHA 0607fd9View commit details -
Migrate all RAC render props to data attributes (#4891)
* added corresponding data-attributes * update docs and selectors to data atrributes * fix typos * update example css and add some missing data attributes * reword styling, update data attributes * update css pseudo classes to data attributes * convert other html attributes to data attributes * update css in docs * revert meter data attribute * fix tests * fix data-sort-direction in table * revert spacing changes to meter * update data attributes, fix css
1Configuration menu - View commit details
-
Copy full SHA for 1ef9091 - Browse repository at this point
Copy the full SHA 1ef9091View commit details -
Testing documentation and util RFC (#4835)
* rfc rough draft * adding some more links
1Configuration menu - View commit details
-
Copy full SHA for 1a41685 - Browse repository at this point
Copy the full SHA 1a41685View commit details -
Revert fix(#4313): ariaHideOutside/aria-modal-polyfill: use inert ins…
1Configuration menu - View commit details
-
Copy full SHA for 8987f92 - Browse repository at this point
Copy the full SHA 8987f92View commit details
Commits on Aug 22, 2023
-
1
Configuration menu - View commit details
-
Copy full SHA for 4ce4d1d - Browse repository at this point
Copy the full SHA 4ce4d1dView commit details
Commits on Aug 23, 2023
-
1
Configuration menu - View commit details
-
Copy full SHA for dc61485 - Browse repository at this point
Copy the full SHA dc61485View commit details -
Adds check to detect Android pointer type as touch (#4940)
* add additonal check to detect virtual event * fix logical operator * add unit test * remove console log and update unit test * remove extra spacing, fix test * remove only from test * fix teset
1Configuration menu - View commit details
-
Copy full SHA for 9b2c2e1 - Browse repository at this point
Copy the full SHA 9b2c2e1View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 145c903 - Browse repository at this point
Copy the full SHA 145c903View commit details
Commits on Aug 24, 2023
-
1
Configuration menu - View commit details
-
Copy full SHA for e35ab0d - Browse repository at this point
Copy the full SHA e35ab0dView commit details -
RAC: add Tailwind plugin for RAC states (#4933)
* add tailwind plugin for RAC states * add docs * add option for prefix * update docs to mention prefix option * update to use data-rac attribute * change focused->focus and hovered->hover * update example app to use plugin * fix selector * fix test * add native element to test app * temp run verdaccio build * temp run verdaccio build * revert verdaccio * typo
1Configuration menu - View commit details
-
Copy full SHA for 5f69479 - Browse repository at this point
Copy the full SHA 5f69479View commit details -
Hidden text field is focusable and editable with Select with isDisabl…
…ed=true (#4943) * pass isDisabled prop to HiddenSelect * Add test --------- Co-authored-by: Robert Snow <rsnow@adobe.com>
1Configuration menu - View commit details
-
Copy full SHA for 13a2792 - Browse repository at this point
Copy the full SHA 13a2792View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 9669c44 - Browse repository at this point
Copy the full SHA 9669c44View commit details
Commits on Aug 25, 2023
-
Keep focus on last pressed column header through loading state (#4249)
* Keep focus on last pressed column header through loading state * fix lint * add comment * add manager focused condition * no tabbing to column headers when table is empty * cleanup focus if table becomes empty * fix lint * fix focus target on blur * update story to trigger empty state on 2nd press of table column header * simplify * fix tests * fix issue where items cutoff focus ring on entire collection * Add test * revert logic to focus first item * fix test * fix box shadow cutoff --------- Co-authored-by: Daniel Lu <dl1644@gmail.com> Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Danni <darobins@adobe.com>
1Configuration menu - View commit details
-
Copy full SHA for 3b390fd - Browse repository at this point
Copy the full SHA 3b390fdView commit details
Commits on Aug 26, 2023
-
Fix Unavailable Menu Item's Popover positioning (#4917)
* show overflow of popover * detect if scroll is prevented in position calc * add docs example to see fix * only overflow when submenus are shown * Fix menu clipping corners * only make overflow visible on menus * update type * revert docs change --------- Co-authored-by: Rob Snow <rsnow@adobe.com>
1Configuration menu - View commit details
-
Copy full SHA for 8d367e0 - Browse repository at this point
Copy the full SHA 8d367e0View commit details
Commits on Aug 28, 2023
-
1
Configuration menu - View commit details
-
Copy full SHA for 2f32c05 - Browse repository at this point
Copy the full SHA 2f32c05View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for e02d205 - Browse repository at this point
Copy the full SHA e02d205View commit details
Commits on Aug 29, 2023
-
Add
isPending
prop toButton
component which triggers a spinner. (#……4900) * Add `isPending` prop to `Button` component which triggers a spinner. * Fix lint errors * Added test * Only import the necessary package from react-aria * Remove unnecessary timeout ref. * Remove pointer events override * Update test * Add hook to filter out interactions during pending * Added cases to story * update pending story * whitespace fix * update pending story * update pending story * remove spacing override on loader icon * make anchor button-like things disabled when pending * update button docs * Simplify button story * Update isPending tests * Apply progressCircle overBackground to static color buttons * Style display with visibility instead of opacity * Improve vertical centering of spinner * Remove extra dependency * Added more disabled props while pending * Update Pending docs * Rename function so it doesn't sound like a hook * Defense * Use proper naming convention * Simplify story naming * Update test * Add aria-live to pending button when pending * Add check that spinner isn't in document * Remove cruft * Move progressCircle props to component * Fix typos Co-authored-by: Robert Snow <rsnow@adobe.com> * change story action * fix typo * Add additional info to isPending type comment * Fix lint problem * Remove focus and blur from blocked events * prefix isPending with UNSTABLE * remove doc changes for now * Revert unintended change --------- Co-authored-by: Robert Snow <rsnow@adobe.com>
1Configuration menu - View commit details
-
Copy full SHA for 53ddbb6 - Browse repository at this point
Copy the full SHA 53ddbb6View commit details -
* initialize dropzone * brainstorm * cleanup dropzone * merge * update stories with actions * messages * use rac dropzone * input stuff * add css, change dropzone ref * set isFilled * add css, trying stuff in dropzone * add unfilled/filled state * added bannerMessage and isFilled prop, update stories * clean up stories * added a test * updated css, exported Draggable, clean up package.json * add imperative handle - tbd whether it is kept * cleanup * fix react-aria-component dependency * create new css folder for dnd stories * add text component to story * add spacing, add tests, whcm css * clean up rac dropzone * add more tests * fix typo * fix stories, fix typo in css, remove focus styling * added jsdoc comments, new story, export types * add css to new story, change examples to buttons, minor css changes * fix linting * fix typo * remove imperative handler from dropzone * fix tests * fix typo * update css to match new style for banner, update css for whcm * fix typo, add draggable image to story * update text color to meet color contrast * fix indentation * fix indentation * update package * update css and tests, styled filled state for stories, message announces on VO * update useId import * small code review changes * fix HCM * fix lint * add missing filter dom props to filetrigger * further hcm fixes * update stories with text component --------- Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Daniel Lu <dl1644@gmail.com>
1Configuration menu - View commit details
-
Copy full SHA for 6f39866 - Browse repository at this point
Copy the full SHA 6f39866View commit details -
Fix RadioGroup lost roving tab index (#4985)
* Fix RadioGroup lost roving tab index
1Configuration menu - View commit details
-
Copy full SHA for a633130 - Browse repository at this point
Copy the full SHA a633130View commit details
Commits on Aug 30, 2023
-
Add translations to RSP Dropzone (#4989)
* Add translations to RSP Dropzone * update name for clarity
1Configuration menu - View commit details
-
Copy full SHA for d4d21a7 - Browse repository at this point
Copy the full SHA d4d21a7View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 64e3590 - Browse repository at this point
Copy the full SHA 64e3590View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 1c14740 - Browse repository at this point
Copy the full SHA 1c14740View commit details -
Add a link to storybook (#4996)
* Add a link to storybook * Swap single quote for backtick
1Configuration menu - View commit details
-
Copy full SHA for 3276459 - Browse repository at this point
Copy the full SHA 3276459View commit details
Commits on Aug 31, 2023
-
[RAC] Table - allow passing render prop to Cell (#4995)
* Table - allow passing render prop * Fix forwardRef type --------- Co-authored-by: Devon Govett <devongovett@gmail.com> Co-authored-by: Reid Barber <reid@reidbarber.com>
1Configuration menu - View commit details
-
Copy full SHA for ea35ed0 - Browse repository at this point
Copy the full SHA ea35ed0View commit details -
Adding Unavailable Menu Item docs (#4763)
* Adding Unavailable Menu Item docs * removing similar text * rewording two concepts * fix spelling mistakes Co-authored-by: Michael Jordan <mijordan@adobe.com> * Adding more explanation in a couple cases * using the Unavailable Items as the name * switching the order of two paragraphs * update docs and types * fix props table * update types and docs table * address review comments --------- Co-authored-by: Michael Jordan <mijordan@adobe.com> Co-authored-by: Reid Barber <reid@reidbarber.com> Co-authored-by: Daniel Lu <dl1644@gmail.com> Co-authored-by: Robert Snow <rsnow@adobe.com>
1Configuration menu - View commit details
-
Copy full SHA for 30f1728 - Browse repository at this point
Copy the full SHA 30f1728View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for e7b9c16 - Browse repository at this point
Copy the full SHA e7b9c16View commit details
Commits on Sep 1, 2023
-
1
Configuration menu - View commit details
-
Copy full SHA for 9255da6 - Browse repository at this point
Copy the full SHA 9255da6View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 67c19ff - Browse repository at this point
Copy the full SHA 67c19ffView commit details -
Fix missing peerDependency on react-dom (#5002)
* Fix missing peerDependency on react-dom Fixes #4934 * add a package lint for peer deps --------- Co-authored-by: Robert Snow <rsnow@adobe.com>
1Configuration menu - View commit details
-
Copy full SHA for 7fe63ab - Browse repository at this point
Copy the full SHA 7fe63abView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 3b92155 - Browse repository at this point
Copy the full SHA 3b92155View commit details
Commits on Sep 2, 2023
-
Fix buttongroup infinite update loop (#5010)
* Fix buttongroup infinite update loop
1Configuration menu - View commit details
-
Copy full SHA for 2600c96 - Browse repository at this point
Copy the full SHA 2600c96View commit details
Commits on Sep 5, 2023
-
Make all submenus close upon user interact outside (#4988)
* Make all submenus close upon user interact outside * add test * refactor to close on underlay press * turns out we dont need the ref * restrict to spectrum for now adding the logic to useOverlay brings up the possibility where a user could have a dismissible overlay open a non dismissible overlay but the absense of a underlay for the non dismissible overlay would then make the click on the dismissible overlay's underlay close both overlays which is different behavior from before. Isolating this change to spectrum for our submenu case until we implement something like focusscope tree to detect clicks outside the tree of menus
1Configuration menu - View commit details
-
Copy full SHA for 07260d1 - Browse repository at this point
Copy the full SHA 07260d1View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for e89b9bc - Browse repository at this point
Copy the full SHA e89b9bcView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 061007a - Browse repository at this point
Copy the full SHA 061007aView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for cea5511 - Browse repository at this point
Copy the full SHA cea5511View commit details
Commits on Sep 6, 2023
-
fix: useSelect trigger label (#4949)
* fix: useSelect trigger label * fix lint and tests * fix: fixed label merge logic * fix tests --------- Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Daniel Lu <dl1644@gmail.com>
1Configuration menu - View commit details
-
Copy full SHA for 50b1e19 - Browse repository at this point
Copy the full SHA 50b1e19View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 2a98c9f - Browse repository at this point
Copy the full SHA 2a98c9fView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 4e51283 - Browse repository at this point
Copy the full SHA 4e51283View commit details -
Move ContextualHelpTrigger docs to Menu (#5017)
* Move ContextualHelpTrigger docs to Menu * import Keyboard * forgot to save --------- Co-authored-by: Robert Snow <rsnow@adobe.com>
1Configuration menu - View commit details
-
Copy full SHA for a39ac2f - Browse repository at this point
Copy the full SHA a39ac2fView commit details -
Remove erroneous accessibility color contrast ignore rule (#5029)
investigated, turns out it is a legitimate color contrast problem
1Configuration menu - View commit details
-
Copy full SHA for c961c55 - Browse repository at this point
Copy the full SHA c961c55View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for b0c7300 - Browse repository at this point
Copy the full SHA b0c7300View commit details
There are no files selected for viewing