-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Comparing changes
Open a pull request
base repository: adobe/react-spectrum
base: react-aria@3.37.0
head repository: adobe/react-spectrum
compare: react-aria@3.38.0
Commits on Jan 15, 2025
-
chore: Update test util doc examples so they don't error out (#7612)
* Fixes to test util and docs * forgot to save a file * fix docs * review comments
Configuration menu - View commit details
-
Copy full SHA for 80f8a2b - Browse repository at this point
Copy the full SHA 80f8a2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09e7f44 - Browse repository at this point
Copy the full SHA 09e7f44View commit details -
2
Configuration menu - View commit details
-
Copy full SHA for 75b74b1 - Browse repository at this point
Copy the full SHA 75b74b1View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 78683ee - Browse repository at this point
Copy the full SHA 78683eeView commit details -
fix: React inert prop compatibility (#7519)
* fix: React inert prop compatibility * chore: lint * Check using `React.version` * Fix type * fix lint --------- Co-authored-by: GitHub <snowystinger@gmail.com> Co-authored-by: Robert Snow <rsnow@adobe.com>
1Configuration menu - View commit details
-
Copy full SHA for 55dc352 - Browse repository at this point
Copy the full SHA 55dc352View commit details -
fix(@react-aria/selection): don't mutate non-empty selection upon foc…
1Configuration menu - View commit details
-
Copy full SHA for 6806410 - Browse repository at this point
Copy the full SHA 6806410View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for ce54e26 - Browse repository at this point
Copy the full SHA ce54e26View commit details
Commits on Jan 16, 2025
-
1
Configuration menu - View commit details
-
Copy full SHA for 1286a65 - Browse repository at this point
Copy the full SHA 1286a65View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 2b563a6 - Browse repository at this point
Copy the full SHA 2b563a6View commit details -
docs: fix typo in Slider (#7621)
* Replace comma operator with semicolon for better readability Closes #5820 * docs: Update Slider.mdx * fix other typo --------- Co-authored-by: Reid Barber <reid@reidbarber.com>
1Configuration menu - View commit details
-
Copy full SHA for 1547e25 - Browse repository at this point
Copy the full SHA 1547e25View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for df3f1ea - Browse repository at this point
Copy the full SHA df3f1eaView commit details
Commits on Jan 17, 2025
-
refactor: No longer preventDefault in usePress and allow browser to m…
…anage focus (#7542) * working first pass * Update mouse and touch handlers as well * Always set a tabIndex on native buttons and inputs so Safari focuses them * lint * Update tests * Make grid selection announcement more resilient to focus order * Remove focus during virtual clicks #5940 * Add test story for #7480 * Add story for #6512 * Make sure to cancel press if onClick's propagation is stopped For #5833 * fix ts * Use focusWithoutScrolling when restoring focus
1Configuration menu - View commit details
-
Copy full SHA for cdba748 - Browse repository at this point
Copy the full SHA cdba748View commit details
Commits on Jan 21, 2025
-
1
Configuration menu - View commit details
-
Copy full SHA for 2a1c28b - Browse repository at this point
Copy the full SHA 2a1c28bView commit details
Commits on Jan 22, 2025
-
fix: add isFocusVisible useMenuItem and fix focusRing when typing in …
…Autocomplete SearchField (#7625) * add isFocusVisible support to useMenuItem * Adding tests and style in storybook * fix: (WIP) Fix autocomplete searchfield focus ring (#7626) * for discussion * fix searchfield focus ring appearing on keypress when wrapped in a autocomplete * add test * remove extranous controls
1Configuration menu - View commit details
-
Copy full SHA for 9bb6ed9 - Browse repository at this point
Copy the full SHA 9bb6ed9View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 7b7b461 - Browse repository at this point
Copy the full SHA 7b7b461View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 3e1c518 - Browse repository at this point
Copy the full SHA 3e1c518View commit details
Commits on Jan 24, 2025
-
feat: add overflowMode to S2 Badge (#7653)
* feat: add overflowMode to S2 Badge * fix spelling * fix spelling in api diff
1Configuration menu - View commit details
-
Copy full SHA for 873f6fe - Browse repository at this point
Copy the full SHA 873f6feView commit details
Commits on Jan 27, 2025
-
feat: GridList autoFocus (#7640)
* feat: GridList autoFocus * Update packages/@react-aria/gridlist/src/useGridList.ts Co-authored-by: Reid Barber <reid@reidbarber.com> --------- Co-authored-by: Reid Barber <reid@reidbarber.com>
1Configuration menu - View commit details
-
Copy full SHA for f6e1bd9 - Browse repository at this point
Copy the full SHA f6e1bd9View commit details -
fix: tablist auto selection (#7529)
* Fix tabs auto selection * fix lint * see if it passes on CI * remove forced selection in controlled * add a little more to the test
1Configuration menu - View commit details
-
Copy full SHA for fd7075c - Browse repository at this point
Copy the full SHA fd7075cView commit details
Commits on Jan 28, 2025
-
fix: dayperiod segment no longer resets when hour deleted (#7506)
* fix: dayperiod segment no longer reset * undo prettier * add test --------- Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
1Configuration menu - View commit details
-
Copy full SHA for c4bd19d - Browse repository at this point
Copy the full SHA c4bd19dView commit details -
fix: Fix focusing radio, checkbox, and switch on press (#7677)
* Fix iOS delay for click event * Fix focusing radio, checkbox, and switch on label press
1Configuration menu - View commit details
-
Copy full SHA for cbdf710 - Browse repository at this point
Copy the full SHA cbdf710View commit details
Commits on Jan 29, 2025
-
fix: correctly format date/time in RTL (#7423)
* bdo on timefield, reverse segments on timefield in datefield * fix lint * make things inline * use unicode character to wrap segments * fix test * append unicode to text in hooks, update rac * add comment * skip failing test for now * update keyboard nav * update logic of how unicode is applied * fix spacing * add comments * update tests * undo some previous changes * wrap time segments in lri, wrap fields in unicode isolate * fix ssr test * fix spacing * fix css logic * fix lint * fix keyboard nav in rac datepicker popover * fix lint * prevent overflow in date range picker * move overflow hidden to separate new div to fix weird focus ring around the button * this time actually fix the overflow and focus ring issue * update var names to be nicer * fix japanese placeholder for extra space * fix css positioning * fix custom width * small css changes so that rtl will format properly * memo ordering of segments for keyboard navigation * add chromatic tests * fix lint * add tests to rsp date components * add tests to rac * fix tests * remove comment * fix chromatic stories * add chromatic story * remove style tests * fix lint * update to uselayouteffect and update keyboard nav test * make date input more consistent with using display inline * update timefield docs css to use display inline * fix showFormatHelpText * small change * fix lint * add divs to keyboard navigation so it works with older versions * fix lint + fix tests
1Configuration menu - View commit details
-
Copy full SHA for e228ed8 - Browse repository at this point
Copy the full SHA e228ed8View commit details -
feat: Update to Tailwind v4 (#7669)
* initial upgrade * Update plugin, homepage, and examples * fix jest resolver * Update tailwind starter * Update rac-tailwind example app * Update rac-spectrum-tailwind example * enable verdaccio build * update tailwind-variants * patch * update lockfile * missing dependency * copy patches when building website * dedupe lightningcss * Update styling page * Fix TextField focus state * revert verdaccio * fix typo
1Configuration menu - View commit details
-
Copy full SHA for 9efdd3b - Browse repository at this point
Copy the full SHA 9efdd3bView commit details -
fix(Select): HiddenSelect Component Auto-Completion Issue (#7670)
* address autofill issue * lint * remove unnecessary change * Update packages/@react-aria/select/src/HiddenSelect.tsx Co-authored-by: Robert Snow <snowystinger@gmail.com> * remove unnecessary variable declaration --------- Co-authored-by: Robert Snow <snowystinger@gmail.com> Co-authored-by: Reid Barber <reid@reidbarber.com>
1Configuration menu - View commit details
-
Copy full SHA for beb8bd5 - Browse repository at this point
Copy the full SHA beb8bd5View commit details -
* Render a TreeView * Correct styles * update styles to better fix s2 * fix install * fix lint, add preliminary test * fix lint * Add tests and test util * save point * Add emptyState * fix lint * detached styles * detached styling with actions * fix disabled, icon placement, and add examples * fix lint * update snapshots * fix lint and tests * fix imports * Match row selection to table * fix lint, again * feat: S2 treeview virtualized (#7465) * feature: s2 treeview virtualization * support both detached and non in the layout * fix lint * fix height for docs * default tree disabled behavior to all to match our other components * fix tests * update snapshots * fix lint * fix alignment and remove minwidth * increase gap between detached items * remove restriction for isDetached and isEmphasized * fix border radius * review comments * fix lint
1Configuration menu - View commit details
-
Copy full SHA for e3ed3c7 - Browse repository at this point
Copy the full SHA e3ed3c7View commit details
Commits on Jan 31, 2025
-
fix: top/left align icon in s2 badge (#7691)
* fix: top/left align icon in s2 badge * center icon only badge
1Configuration menu - View commit details
-
Copy full SHA for b86dc20 - Browse repository at this point
Copy the full SHA b86dc20View commit details -
chore: Refactor S2 tabs to fix accessibility issues (#7600)
* wip: Refactor S2 tabs to fix accessibility issues * yarn * review comments * fix lint * fix orientation case * Fix orientation case not updating overflow * Add required labelling and other review comments * fix a few more announcements * fix lint * fix chromatic * remove translations * fix announcements * fix lint --------- Co-authored-by: GitHub <snowystinger@gmail.com> Co-authored-by: Robert Snow <rsnow@adobe.com>
Configuration menu - View commit details
-
Copy full SHA for 016590a - Browse repository at this point
Copy the full SHA 016590aView commit details -
[5574] - add moveBefore and moveAfter to useTreeData (#7689)
* [5574] - add moveBefore and moveAfter to useTreeData * add docs * remove onlys * remove console logs
1Configuration menu - View commit details
-
Copy full SHA for 1ba8f01 - Browse repository at this point
Copy the full SHA 1ba8f01View commit details -
chore: follow-up for rtl date/time format (#7685)
* add comments to explain unicode stuff * add blurb about the css changes in rac docs * add spacing to showFormatHelpText
1Configuration menu - View commit details
-
Copy full SHA for 41ef71d - Browse repository at this point
Copy the full SHA 41ef71dView commit details
Commits on Feb 3, 2025
-
feat: Allow ReactElement in LabeledValue value (#7679)
* Allow ReactNode as LabeledValue value * Add useEffect * Fix linter errors * Fix error case tests * fix story * Remove todo * Fix error test * Add docs * Fix linter * Remove console.error check * Fix docs * Fix lint errors * Fix lint errors * Update to use ReactElement * Update packages/@react-spectrum/labeledvalue/stories/LabeledValue.stories.tsx * Fix errorMessage test --------- Co-authored-by: Sana Malik <sanmalik@adobe.com> Co-authored-by: Reid Barber <reid@reidbarber.com> Co-authored-by: Robert Snow <snowystinger@gmail.com>
1Configuration menu - View commit details
-
Copy full SHA for 2905848 - Browse repository at this point
Copy the full SHA 2905848View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 4b641a7 - Browse repository at this point
Copy the full SHA 4b641a7View commit details -
fix: save render through optimized useSlot() (#7270)
* allow for initializing slot with a false state * save slot render in checkboxgroup * save slot render in radiogroup * save slot render in meter * save render in select * save render in timefield * save render in datefield * save render in hexcolorfield * save render in colorchannelfield * save render in progressbar * saver render in combobox * save render in searchfield * save render in numberfield * save render in taggroup * save render in textfield * save render in colorslider * save render in slider * save render in datepicker * Update packages/react-aria-components/src/utils.tsx --------- Co-authored-by: Robert Snow <snowystinger@gmail.com>
1Configuration menu - View commit details
-
Copy full SHA for cfcd697 - Browse repository at this point
Copy the full SHA cfcd697View commit details -
feat: improve literal search for member expressions (#7604)
Co-authored-by: Robert Snow <rsnow@adobe.com>
1Configuration menu - View commit details
-
Copy full SHA for 4322a3e - Browse repository at this point
Copy the full SHA 4322a3eView commit details
Commits on Feb 4, 2025
-
1
Configuration menu - View commit details
-
Copy full SHA for 9d70953 - Browse repository at this point
Copy the full SHA 9d70953View commit details -
fix: infinite re-render on reoccuring ids (#7657)
* fix: infinite re-render on reoccuring ids * fix: useId effect cleanup * fix: react 19 compatibility * fix: typo * fix: jest anything matcher * fix: match optional anything * fix: react 16 fc & assertion * chore: remove nvmrc upgrade --------- Co-authored-by: Robert Snow <rsnow@adobe.com>
1Configuration menu - View commit details
-
Copy full SHA for a861ca4 - Browse repository at this point
Copy the full SHA a861ca4View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for eae712a - Browse repository at this point
Copy the full SHA eae712aView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 939205c - Browse repository at this point
Copy the full SHA 939205cView commit details
Commits on Feb 5, 2025
-
chore: updating the code of conduct to newer version (#7693)
* updating the code of conduct to newer version * Update CONTRIBUTING.md --------- Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Danni <darobins@adobe.com>
1Configuration menu - View commit details
-
Copy full SHA for 2788d8a - Browse repository at this point
Copy the full SHA 2788d8aView commit details -
* fix: S2 Badge context * fix lint
1Configuration menu - View commit details
-
Copy full SHA for 6c4c57d - Browse repository at this point
Copy the full SHA 6c4c57dView commit details
Commits on Feb 6, 2025
-
feat: Focus Management within ShadowDOM (#6046)
* Add `getRootNode` utility. * Update `getRootNode` util. Update domHelpers.test.js. * Update `getOwnerWindow` util. * Add tests for Shadow DOM handling using `getRootNode`. * Update comment. * Fix FocusScope.tsx in Shadow DOM. Add Tests for FocusScope.test.js. New helper util `getRootBody`. * Add more test for FocusScope.test.js. Fix `useRestoreFocus` issue. Add new DOM util `getDeepActiveElement`. * Fix another `useRestoreFocus` issue with restoring focus in `Keyboard navigation example`. * Add tests for `getDeepActiveElement` * Add `useFocus` shadow DOM tests. update `useFocus` - `useFocusWithin` - `usePress`. * Update `focusSafely`. Test for `focusSafely`. * Update `useInteractionOutside` for Shadow DOM support. * Update `useFocusVisible` for Shadow DOM support. * Add `useInteractOutside` tests. * Add test for use case mentioned in issue #1472. * Add tests for `usePress` hook. * Update the fix for `useInteractOutside` to use simpler one. * Update `useOverlay` to use composedPath. * Tests refactor. * Revert `useOverlay` changes as it works correctly without these changes. * Fix types. * Fix types. * lint. * lint. * Fix failing tests. * Fix failing tests. * Fix failing tests. * Test CI * Test CI * Fix shadow DOM tests * Fix shadow DOM tests. * Fix CI? * Fix CI? * Fix CI? * Re-add commented test. * Update `getRootNode` to handle iframes as well, and everything that `getOwnerDocument` used to handle. * Fix tests. * Fix tests? * Fix tests? * Fix tests. * Fix tests.? * Fix tests.? * Fix tests.? * Fix tests.? * Apply suggestions from code review Co-authored-by: Robert Snow <snowystinger@gmail.com> * Update packages/@react-aria/interactions/test/usePress.test.js Co-authored-by: Robert Snow <snowystinger@gmail.com> * - Update tests to use `createShadowRoot` util. - Update `getRootNode` to return null for disconnected nodes. - Update `usePress.test.js` shadow DOM test. - Test getting rid of reactDomRenderer. * - Update tests and remove reactCompat. * - Leftover. * - Revert changes to getFocusableTreeWalker. * - Remove casting. * - return null in case element is disconnected in `getRootNode`. * - Casting. * - Update unit test. * - Handle focus movements between shadow DOMs. * - TS fixes. * Update usePress.test.js * Refactors and TS errors. * Update fix. * Remove broken sandbox link. * Refactor `getRootNode` to improve root node handling. * Use `getDeepActiveElement` inside focusSafely.ts to get the active element. * Refactor event listener registration Introduce `createEventListener` function to streamline event listener registration. This enhances readability and maintainability, ensuring consistency across event handling logic. * Remove `ownerDocument` fallback in usePress.ts * Refactor `createEventListener` for type-safe caching. * - Test out the updated getOwnerWindow to fix iframe focus issues. * - Test out the updated getOwnerWindow to fix iframe focus issues. * - Test? * - Revert Focus scope changes, for testing. * - Fix tests? * - Fix tests? * - Fix tests? * - Revert the changes to getRootNode. * - Revert `isElementInScope` as well. * - Test out if instance check failure across context for iframes is what is causing the issue. * - Replace the use of `instanceof` with `nodeType` to correctly identify the node type across contexts. - Revert changes made for `usePress`. * - Fix ESlint errors. * - Update the usages of `instanceof` to use `nodeType` instead. * Update packages/@react-aria/interactions/src/useFocusVisible.ts Co-authored-by: Robert Snow <snowystinger@gmail.com> * - Update the usages of `instanceof` to use `nodeType` instead. - Introduce new helpers `isShadowRoot` and `isDocument`. * - Lint. * - Lint. * - Update `getDeepActiveElement` to accept an optional document or shadowRoot. - Fix an issue where opening any popover, the focus wasn't restored to the trigger element in shadow DOM. * - Add extra unit test for `getDeepActiveElement`. * - Update `getDeepActiveElement` to always rely on `getRootNode`. * - Update `getDeepActiveElement` to always rely on `getRootNode`. * refactor usePress to still have global listeners for cleanup across boundaries * fix lint and test * restore remaining document level listeners * fix tests * fix lint * simplify * Update packages/@react-aria/focus/src/FocusScope.tsx * fix autofocus * minor test updates to preserve test intent * review comments * fix esm test * fix lint * check in speed tests * fix lint * Add feature flag and fix a couple probable bugs * Update NOTICE.txt --------- Co-authored-by: Ritesh Kumar <ritz078@users.noreply.github.com> Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Robert Snow <snowystinger@gmail.com> Co-authored-by: Daniel Lu <dl1644@gmail.com>
1Configuration menu - View commit details
-
Copy full SHA for c78b248 - Browse repository at this point
Copy the full SHA c78b248View commit details -
feat: implemented details prop to the getItems function in the useCli…
…pboard hook (#7727) * feat: implemented details prop to the getItems function in the useClipboard hook * fix: linting * trigger build with correct email
1Configuration menu - View commit details
-
Copy full SHA for 42cfe68 - Browse repository at this point
Copy the full SHA 42cfe68View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for ac55911 - Browse repository at this point
Copy the full SHA ac55911View commit details
Commits on Feb 7, 2025
-
fix: prevent menu item focus ring from exceeding popover boundaries (#…
…7672) * fix: prevent menu item focus ring from exceeding the boundaries of the popover * try diff css changes...
1Configuration menu - View commit details
-
Copy full SHA for 801ef48 - Browse repository at this point
Copy the full SHA 801ef48View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 0a3204c - Browse repository at this point
Copy the full SHA 0a3204cView commit details -
feat(Toast): use View Transition API for Toast animations (#7631)
* remove animation code from toast hooks * add View Transitions * lint * fix invalid viewTransitionName * fix Multiple story * fix transition when programmatically closing toast * fix slide in/out * fix ts-ignore * update yarn.lock * memoize placement * add placement to fullscreen story * fade out toasts that are centered, and not the last one * lint * add wrapUpdate option to ToastQueue * update where runWithWrapUpdate gets called * fix function param
1Configuration menu - View commit details
-
Copy full SHA for ff300df - Browse repository at this point
Copy the full SHA ff300dfView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for cc08a8d - Browse repository at this point
Copy the full SHA cc08a8dView commit details
Commits on Feb 10, 2025
-
chore: add autofill stories (#7722)
* chore: add autofill stories * add more components to form stories * make autocomplete form more realistic * rename story * fix lint * add picker to s2 form story
1Configuration menu - View commit details
-
Copy full SHA for fb3b865 - Browse repository at this point
Copy the full SHA fb3b865View commit details -
chore: Update spectrum tokens (#7736)
* chore: update spectrum tokens * fix chromatic stories label ordering * fix remaining stories * fix flaky story * update remaining instance of tokens * Revert chromatic changes and mergeProps order * fix lint * stabilize colorswatchpicker again
1Configuration menu - View commit details
-
Copy full SHA for e8de3f8 - Browse repository at this point
Copy the full SHA e8de3f8View commit details -
fix: Autocomplete 'tab' key forwarding (#7724)
* fix: Autocomplete 'tab' key forwarding * fix react 16 compatibility * make better story name * use daniel's fix * Update packages/react-aria-components/test/Autocomplete.test.tsx
1Configuration menu - View commit details
-
Copy full SHA for 4b8b33a - Browse repository at this point
Copy the full SHA 4b8b33aView commit details
Commits on Feb 11, 2025
-
chore(s2): fix S2 children and context types (#7668)
* fix S2 children and context types * fix chromatic types? * missed one * switch some children types back to optional * fix types * fix types * types * review comment
1Configuration menu - View commit details
-
Copy full SHA for 735b275 - Browse repository at this point
Copy the full SHA 735b275View commit details
There are no files selected for viewing