Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: adobe/react-spectrum
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @react-aria/calendar@3.5.7
Choose a base ref
...
head repository: adobe/react-spectrum
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @react-aria/calendar@3.5.8
Choose a head ref

Commits on May 2, 2024

  1. Fix versions

    devongovett committed May 2, 2024
    Copy the full SHA
    f6d37e9 View commit details
  2. 1
    Copy the full SHA
    f645f29 View commit details
  3. April release notes (#6247)

    * initialize release notes
    
    ---------
    
    Co-authored-by: Danni <darobins@adobe.com>
    Co-authored-by: Devon Govett <devongovett@gmail.com>
    3 people authored May 2, 2024
    1
    Copy the full SHA
    6608813 View commit details
  4. Submenu blog post (#6143)

    * add submenu blog post
    
    * fix font family in svgs
    
    * improve pointer angle svg in dark mode and mobile
    
    * address review comments and other improvements
    
    * address review comments
    
    * address review comments
    
    * update date
    
    ---------
    
    Co-authored-by: Robert Snow <rsnow@adobe.com>
    reidbarber and snowystinger authored May 2, 2024
    1
    Copy the full SHA
    c9f3bbe View commit details
  5. Fix next.js config syntax (#6315)

    `next.config.js` only allows commonjs syntax, not ESM. And you need to install the glob package before you can use it.
    devongovett authored May 2, 2024
    1
    Copy the full SHA
    c81c946 View commit details
  6. Change word in @internationalized/number readme (#6321)

    Great set of tools. Thank you
    
    Arab: person, ethno-linguistic category
    Arabic: language
    
    Co-authored-by: omar <omaraziz.dev@proton.me>
    yihuiliao and o-az authored May 2, 2024
    1
    Copy the full SHA
    4864fab View commit details

Commits on May 3, 2024

  1. Fix infinite resizing issue in overlay positioning (#6312)

    * Fix infinite resizing issue in overlay positioning
    
    * Fix arrow position
    
    ---------
    
    Co-authored-by: Daniel Lu <dl1644@gmail.com>
    devongovett and LFDanLu authored May 3, 2024
    1
    Copy the full SHA
    800f9a0 View commit details
  2. 1
    Copy the full SHA
    122d0c8 View commit details
  3. 1
    Copy the full SHA
    cf0846e View commit details

Commits on May 7, 2024

  1. chore: Fix typos (#6334)

    wojtekmaj authored May 7, 2024
    1
    Copy the full SHA
    d157bbd View commit details

Commits on May 8, 2024

  1. Storybook 7 (#6150)

    * Storybook 7
    snowystinger authored May 8, 2024
    Copy the full SHA
    8ed86d8 View commit details

Commits on May 9, 2024

  1. Copy the full SHA
    bf8acd2 View commit details
  2. Update GalleryLayout.tsx (#6328)

    avaliable -> available
    
    Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
    eltociear and yihuiliao authored May 9, 2024
    Copy the full SHA
    d033f23 View commit details
  3. Fix main build (#6353)

    * Fix verdaccio build on main
    snowystinger authored May 9, 2024
    1
    Copy the full SHA
    87d1e19 View commit details

Commits on May 10, 2024

  1. 1
    Copy the full SHA
    45a8728 View commit details

Commits on May 13, 2024

  1. Latest translations (#6356)

    Co-authored-by: Daniel Lu <dl1644@gmail.com>
    rgeraghty and LFDanLu authored May 13, 2024
    1
    Copy the full SHA
    5cacbdb View commit details

Commits on May 16, 2024

  1. Internationalized/NumberParser: fix TS5.5 build errors (#6329)

    Co-authored-by: Daniel Lu <dl1644@gmail.com>
    Renegade334 and LFDanLu authored May 16, 2024
    1
    Copy the full SHA
    e16aa4d View commit details
  2. fix: esm build source mapping url replacement (#6368)

    Co-authored-by: Daniel Lu <dl1644@gmail.com>
    oedotme and LFDanLu authored May 16, 2024
    1
    Copy the full SHA
    d7f78e8 View commit details
  3. move deprecated argTypes.defaultValue to args (Tooltip & Popover) (#6387

    )
    
    Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
    sookmax and yihuiliao authored May 16, 2024
    1
    Copy the full SHA
    b294de8 View commit details
  4. Cache locale dict lest child hooks always re-render (#6185)

    * Cache locale dict lest child hooks always re-render
    
    * Update context.tsx
    
    * fix lint
    
    ---------
    
    Co-authored-by: Robert Snow <rsnow@adobe.com>
    Co-authored-by: Robert Snow <snowystinger@gmail.com>
    Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com>
    4 people authored May 16, 2024
    1
    Copy the full SHA
    d80999e View commit details

Commits on May 20, 2024

  1. Copy the full SHA
    b2f561a View commit details
  2. 1
    Copy the full SHA
    8ad383b View commit details
  3. Bump @swc/helpers in@react-stately/flags to match other packages (#…

    …6379)
    
    * Remove `@swc/helpers` dependency from `@react-stately/flags`
    
    Closes #6378
    
    * Update package.json
    
    Meet requirement for having a dep on swc helpers
    
    ---------
    
    Co-authored-by: Robert Snow <snowystinger@gmail.com>
    Co-authored-by: Daniel Lu <dl1644@gmail.com>
    3 people authored May 20, 2024
    1
    Copy the full SHA
    43e54d1 View commit details
  4. Publish

    devongovett committed May 20, 2024
    2
    Copy the full SHA
    b77d7d5 View commit details
Showing 636 changed files with 8,153 additions and 8,320 deletions.
11 changes: 11 additions & 0 deletions .chromatic-fc/.parcelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"extends": "@parcel/config-default",
"resolvers": ["@parcel/resolver-glob", "parcel-resolver-storybook", "..."],
"transformers": {
"packages/*/*/intl/*.json": ["parcel-transformer-intl"],
"*.{js,mjs,jsm,jsx,es6,cjs,ts,tsx}": [
"@parcel/transformer-js",
"@parcel/transformer-react-refresh-wrap"
]
}
}
2 changes: 1 addition & 1 deletion .chromatic-fc/custom-addons/chromatic/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {expressThemes, locales, scales, themes} from '../../constants';
import {makeDecorator} from '@storybook/addons';
import {makeDecorator} from '@storybook/preview-api';
import {Provider, View} from '@adobe/react-spectrum';
import React, {useEffect} from 'react';
import './disableAnimations.css';
7 changes: 4 additions & 3 deletions .chromatic-fc/main.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@

module.exports = {
core: {
builder: "storybook-builder-parcel",
framework: {
name: "storybook-react-parcel",
options: {},
},
stories: ['../packages/**/chromatic/**/*.chromatic-fc.{js,jsx,ts,tsx}'],
stories: ['../packages/**/chromatic-fc/**/*.stories.{js,jsx,ts,tsx}'],
addons: process.env.NODE_ENV === 'production' ? [] : [
'@storybook/addon-actions',
'@storybook/addon-a11y'
8 changes: 5 additions & 3 deletions .chromatic-fc/manager.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import addons from '@storybook/addons';
import {addons} from '@storybook/manager-api';

addons.setConfig({
showRoots: false,
enableShortcuts: false
enableShortcuts: false,
sidebar: {
showRoots: false,
}
});
7 changes: 4 additions & 3 deletions .chromatic-fc/preview.js
Original file line number Diff line number Diff line change
@@ -12,10 +12,11 @@ configureActions({

export const parameters = {
options: {
storySort: (a, b) =>
a[1].kind === b[1].kind
storySort: (a, b) => {
return a.title === b.title
? 0
: a[1].id.localeCompare(b[1].id, undefined, {numeric: true})
: a.id.localeCompare(b.id, undefined, { numeric: true });
}
},
a11y: {},
layout: 'fullscreen',
11 changes: 11 additions & 0 deletions .chromatic/.parcelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"extends": "@parcel/config-default",
"resolvers": ["@parcel/resolver-glob", "parcel-resolver-storybook", "..."],
"transformers": {
"packages/*/*/intl/*.json": ["parcel-transformer-intl"],
"*.{js,mjs,jsm,jsx,es6,cjs,ts,tsx}": [
"@parcel/transformer-js",
"@parcel/transformer-react-refresh-wrap"
]
}
}
2 changes: 1 addition & 1 deletion .chromatic/custom-addons/chromatic/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {expressThemes, locales, scales, themes} from '../../constants';
import {makeDecorator} from '@storybook/addons';
import {makeDecorator} from '@storybook/preview-api';
import {Provider, View} from '@adobe/react-spectrum';
import React, {useEffect} from 'react';
import './disableAnimations.css';
7 changes: 4 additions & 3 deletions .chromatic/main.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@

module.exports = {
core: {
builder: "storybook-builder-parcel",
framework: {
name: "storybook-react-parcel",
options: {},
},
stories: ['../packages/**/chromatic/**/*.chromatic.{js,jsx,ts,tsx}'],
stories: ['../packages/**/chromatic/**/*.stories.@(js|jsx|ts|tsx)'],
addons: process.env.NODE_ENV === 'production' ? [] : [
'@storybook/addon-actions',
'@storybook/addon-a11y'
8 changes: 5 additions & 3 deletions .chromatic/manager.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import addons from '@storybook/addons';
import {addons} from '@storybook/manager-api';

addons.setConfig({
showRoots: false,
enableShortcuts: false
enableShortcuts: false,
sidebar: {
showRoots: false,
}
});
6 changes: 5 additions & 1 deletion .chromatic/preview.js
Original file line number Diff line number Diff line change
@@ -12,7 +12,11 @@ configureActions({

export const parameters = {
options: {
storySort: (a, b) => a[1].kind === b[1].kind ? 0 : a[1].id.localeCompare(b[1].id, undefined, { numeric: true }),
storySort: (a, b) => {
return a.title === b.title
? 0
: a.id.localeCompare(b.id, undefined, { numeric: true });
}
},
a11y: {},
layout: 'fullscreen'
1 change: 1 addition & 0 deletions .circleci/comment.js
Original file line number Diff line number Diff line change
@@ -76,6 +76,7 @@ async function run() {
body: `Build successful! 🎉
* [View the storybook](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/storybook/index.html)
* [View the storybook-canary](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/storybook-canary/index.html)
* [View the storybook-17](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/storybook-17/index.html)
* [View the storybook-16](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/storybook-16/index.html)
* [View the documentation](https://reactspectrum.blob.core.windows.net/reactspectrum/${process.env.CIRCLE_SHA1}/docs/index.html)`
19 changes: 19 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -412,6 +412,21 @@ jobs:
paths:
- '*/storybook-17/'

storybook-canary:
executor: rsp-large
steps:
- restore_cache:
key: react-spectrum-canary-{{ .Environment.CACHE_VERSION }}-{{ .Environment.CIRCLE_SHA1 }}

- run:
name: build storybook-canary
command: make storybook-canary

- persist_to_workspace:
root: dist
paths:
- '*/storybook-canary/'

docs:
executor: rsp-xlarge
steps:
@@ -588,6 +603,9 @@ workflows:
- storybook-17:
requires:
- install-17
- storybook-canary:
requires:
- install-canary
- docs:
requires:
- install
@@ -610,6 +628,7 @@ workflows:
- storybook
- storybook-16
- storybook-17
- storybook-canary
- docs
- deploy-verdaccio:
requires:
4 changes: 4 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
packages/@react-aria/i18n/server
packages/@spectrum-icons/color/**
packages/@spectrum-icons/ui/**
packages/@spectrum-icons/workflow/**
packages/@spectrum-icons/illustrations/**
packages/@spectrum-icons/express/**
node_modules
packages/*/*/dist
packages/*/*/i18n
packages/react-aria/dist
packages/react-aria/i18n
packages/react-aria-components/dist
packages/react-aria-components/i18n
packages/react-stately/dist
packages/dev/storybook-builder-parcel/preview.js
packages/dev/optimize-locales-plugin/LocalesPlugin.d.ts
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
@@ -51,7 +51,7 @@ module.exports = {
}]
}
}, {
files: ['**/test/**', '**/stories/**', '**/docs/**', '**/chromatic/**', '**/__tests__/**'],
files: ['**/test/**', '**/stories/**', '**/docs/**', '**/chromatic/**', '**/chromatic-fc/**', '**/__tests__/**'],
rules: {
'rsp-rules/no-react-key': [ERROR],
'rsp-rules/act-events-test': ERROR,
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -13,3 +13,5 @@ npm-debug.log
public
storybook-static
test-reports.xml
packages/dev/storybook-builder-parcel/iframe.html
packages/dev/storybook-builder-parcel/preview.js
11 changes: 11 additions & 0 deletions .storybook/.parcelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"extends": "@parcel/config-default",
"resolvers": ["@parcel/resolver-glob", "parcel-resolver-storybook", "..."],
"transformers": {
"packages/*/*/intl/*.json": ["parcel-transformer-intl"],
"*.{js,mjs,jsm,jsx,es6,cjs,ts,tsx}": [
"@parcel/transformer-js",
"@parcel/transformer-react-refresh-wrap"
]
}
}
6 changes: 3 additions & 3 deletions .storybook/custom-addons/descriptions/register.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

import { addons, types } from '@storybook/addons';
import {addons, types} from '@storybook/manager-api';
import { AddonPanel } from '@storybook/components';
import React from 'react';
import { useParameter } from '@storybook/api';
@@ -19,8 +19,8 @@ addons.register(ADDON_ID, (api) => {
addons.add(PANEL_ID, {
type: types.PANEL,
title: 'Description',
render: ({ active, key }) => (
<AddonPanel active={active} key={key}>
render: ({ active }) => (
<AddonPanel active={active}>
<MyPanel />
</AddonPanel>
),
5 changes: 3 additions & 2 deletions .storybook/custom-addons/provider/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React, {useEffect, useState} from 'react';
import addons, { makeDecorator } from '@storybook/addons';
import {getQueryParams} from '@storybook/client-api';
import {addons} from '@storybook/preview-api';
import {makeDecorator} from '@storybook/preview-api';
import {getQueryParams} from '@storybook/preview-api';
import {Provider} from '@react-spectrum/provider';
import {expressThemes, themes, defaultTheme} from '../../constants';

5 changes: 3 additions & 2 deletions .storybook/custom-addons/provider/register.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import addons, { types } from '@storybook/addons';
import {getQueryParams} from '@storybook/client-api';

import {addons, types} from '@storybook/manager-api';
import {getQueryParams} from '@storybook/preview-api';
import {locales} from '../../constants';
import React, {useEffect, useState} from 'react';

4 changes: 2 additions & 2 deletions .storybook/custom-addons/scrolling/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {addons, makeDecorator} from '@storybook/addons';
import {addons} from '@storybook/preview-api';
import clsx from 'clsx';
import {getQueryParams} from '@storybook/client-api';
import {getQueryParams} from '@storybook/preview-api';
import React, {useEffect, useState} from 'react';

function ScrollingDecorator(props) {
4 changes: 2 additions & 2 deletions .storybook/custom-addons/scrolling/register.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {addons, types} from '@storybook/addons';
import {getQueryParams} from '@storybook/client-api';
import {addons, types} from '@storybook/manager-api';
import {getQueryParams} from '@storybook/preview-api';
import React, {useEffect, useState} from 'react';

const ScrollingToolbar = ({api}) => {
4 changes: 2 additions & 2 deletions .storybook/custom-addons/strictmode/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {addons, makeDecorator} from '@storybook/addons';
import {getQueryParams} from '@storybook/client-api';
import {addons, makeDecorator} from '@storybook/preview-api';
import {getQueryParams} from '@storybook/preview-api';
import React, {StrictMode, useEffect, useState} from 'react';

function StrictModeDecorator(props) {
4 changes: 2 additions & 2 deletions .storybook/custom-addons/strictmode/register.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {addons, types} from '@storybook/addons';
import {getQueryParams} from '@storybook/client-api';
import {addons, types} from '@storybook/manager-api';
import {getQueryParams} from '@storybook/preview-api';
import React, {useEffect, useState} from 'react';

const StrictModeToolBar = ({api}) => {
3 changes: 1 addition & 2 deletions .storybook/custom-addons/theme/register.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import {themes} from '@storybook/theming';
import addons from '@storybook/addons';
import {addons} from '@storybook/manager-api';
import {FORCE_RE_RENDER} from '@storybook/core-events';
// temporary until we have a better place to grab it from
import * as packageJSON from '../../../packages/@adobe/react-spectrum/package.json';

// Automatically switch light/dark theme based on system pref.
addons.register('theme-switcher', api => {
let query = window.matchMedia('(prefers-color-scheme: dark)');
let update = () => {
18 changes: 11 additions & 7 deletions .storybook/main.js
Original file line number Diff line number Diff line change
@@ -1,22 +1,26 @@

module.exports = {
core: {
builder: "storybook-builder-parcel",
},
stories: ['../packages/**/stories/*.stories.{js,jsx,ts,tsx}'],

addons: [
'@storybook/addon-actions',
'@storybook/addon-a11y',
'@storybook/addon-controls',
'storybook-dark-mode',
"@storybook/addon-actions",
"@storybook/addon-a11y",
"@storybook/addon-controls",
"storybook-dark-mode",
'./custom-addons/provider/register',
'./custom-addons/descriptions/register',
'./custom-addons/theme/register',
'./custom-addons/strictmode/register',
'./custom-addons/scrolling/register'
],

typescript: {
check: false,
reactDocgen: false
},

framework: {
name: "storybook-react-parcel",
options: {},
}
};
8 changes: 5 additions & 3 deletions .storybook/manager.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import addons from '@storybook/addons';
import {addons} from '@storybook/manager-api';

addons.setConfig({
showRoots: false,
enableShortcuts: false
enableShortcuts: false,
sidebar: {
showRoots: false,
}
});
6 changes: 5 additions & 1 deletion .storybook/preview.js
Original file line number Diff line number Diff line change
@@ -12,7 +12,11 @@ configureActions({

export const parameters = {
options: {
storySort: (a, b) => a[1].kind === b[1].kind ? 0 : a[1].id.localeCompare(b[1].id, undefined, { numeric: true }),
storySort: (a, b) => {
return a.title === b.title
? 0
: a.id.localeCompare(b.id, undefined, { numeric: true });
}
},
a11y: {
config: {
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
@@ -81,6 +81,9 @@ storybook-16:
storybook-17:
yarn build:storybook-17

storybook-canary:
yarn build:storybook-canary

# for now doesn't have deploy since v3 doesn't have a place for docs and stuff yet
ci:
$(MAKE) publish
2 changes: 1 addition & 1 deletion examples/rac-spectrum-tailwind/package.json
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@
"@adobe/react-spectrum": "^3.28.0",
"@spectrum-icons/illustrations": "^3.6.3",
"@spectrum-icons/workflow": "^4.2.2",
"parcel": "2.0.0-canary.1563",
"parcel": "2.0.0-dev.1599",
"postcss": "^8.2.1",
"react": "^18.2.0",
"react-aria-components": "^1.0.0-alpha.4",
2 changes: 1 addition & 1 deletion examples/rac-tailwind/package.json
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@
"@heroicons/react": "^2.0.16",
"@react-aria/parcel-resolver-optimize-locales": "^1.0.0",
"framer-motion": "^10.12.16",
"parcel": "2.0.0-canary.1563",
"parcel": "2.0.0-dev.1599",
"postcss": "^8.4.21",
"react": "^18.2.0",
"react-aria-components": "^1.0.0-alpha.4",
4 changes: 2 additions & 2 deletions examples/rsp-cra-18/package.json
Original file line number Diff line number Diff line change
@@ -5,10 +5,10 @@
"homepage": ".",
"dependencies": {
"@adobe/react-spectrum": "latest",
"@babel/plugin-proposal-private-property-in-object": "^7.16.7",
"@babel/preset-react": "^7.24.1",
"@react-aria/dnd": "^3.5.0",
"@react-spectrum/inlinealert": "^3.0.0-rc.0",
"@react-spectrum/color": "^3.0.0-beta.28",
"@react-spectrum/dropzone": "^3.0.0-beta.0",
"@react-spectrum/toast": "^3.0.0-beta.7",
"@spectrum-icons/workflow": "latest",
"@spectrum-icons/illustrations": "^3.6.8",
2 changes: 1 addition & 1 deletion examples/rsp-cra-18/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import './App.css';
import {Provider, defaultTheme, Item, TagGroup, Cell, Column, Row, TableBody, TableHeader, TableView, Content} from '@adobe/react-spectrum';
import {Provider, defaultTheme, Item, TagGroup, Cell, Column, Row, TableBody, TableHeader, TableView} from '@adobe/react-spectrum';
import Lighting from './Lighting';
import {useState} from 'react'
import BodyContent from './BodyContent';
Loading