Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SideNav to response better #1530

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Update SideNav to response better #1530

merged 1 commit into from
Jul 22, 2023
+1 −0

Conversation

louisachu
Copy link
Collaborator

Update the SideNav visibility

Description

Update the SideNav visibility

Related Issue

https://jira.corp.adobe.com/browse/DEVSITE-694

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

@louisachu louisachu requested a review from timkim as a code owner July 22, 2023 00:18
dmitrymatio
dmitrymatio approved these changes Jul 22, 2023
View reviewed changes
Copy link
Collaborator

@dmitrymatio dmitrymatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@louisachu louisachu merged commit 9692a29 into main Jul 22, 2023
@louisachu louisachu deleted the louisa/DEVSITE-694-PageWidth-sidenav branch July 22, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrymatio dmitrymatio

@timkim timkim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@louisachu @dmitrymatio