NamedFile: added basic ranges header support, added content-length support #227
+85
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good. but could you add test for range response |
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
=========================================
- Coverage 0.62% 0.62% -0.01%
=========================================
Files 93 93
Lines 12608 12617 +9
=========================================
Hits 79 79
- Misses 12529 12538 +9
Continue to review full report at Codecov.
|
|
sigh oh dear github... Added test for status code, content-length header, and range response header. |
|
something is wrong with PR, rebase or squash maybe? |
|
ping |
|
I'm working on it. Somehow a pull messed up my git tree. |
|
Should be fine by now. |
|
thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for the content-length for the NamedFile, since this can be important with big files, since it helps the client to decide to get a whole file or specific chunks from it.
I also added some ranges support as mentioned in #60 . I'm not expecting this getting merged as-is, since I had to modify a helper-type, it works however but not something I'm happy with right now. I shared it with you with the hopes of you'll have a better idea how to do implement this.
I also modified the disposition of the Video types, since it's making sense to watch a video in your browser. To me at least.
There's also some bugginess with the "accept-ranges: bytes" header, since it causing some error messages, and I didn't found the root cause of these, even with a packetcapturing. I'll work on this some more for sure.