Skip to content

Improve French translation #7653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Improve French translation #7653

merged 1 commit into from
Mar 13, 2023

Conversation

cprodhomme
Copy link
Contributor

@cprodhomme cprodhomme commented Sep 28, 2022

  • Etendu du filtre in french is a nonsense. Périmètre is more appropriated

  • Aucun filtres -> Aucun filtre (must be singular)

  • Aucun %{model} trouvé -> Aucun(e) %{model} trouvé(e) : The "model" can be feminine in French 😝

@javierjulio
Copy link
Member

@cprodhomme did you have any other updates for this? What are the reason for the changes? There's no PR description.

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c1deb1e) 99.07% compared to head (77e4ae8) 99.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7653   +/-   ##
=======================================
  Coverage   99.07%   99.07%           
=======================================
  Files         199      199           
  Lines        4976     4976           
=======================================
  Hits         4930     4930           
  Misses         46       46           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@javierjulio
Copy link
Member

I will accept this PR but beforehand would appreciate an update to the PR title and description on the changes and why they are made. Thank you.

@cprodhomme cprodhomme changed the title Update fr.yml Improve french translation Mar 13, 2023
@cprodhomme
Copy link
Contributor Author

cprodhomme commented Mar 13, 2023

@cprodhomme did you have any other updates for this? What are the reason for the changes? There's no PR description.

Hello @javierjulio !

Sorry for the empty pull request.

i just completed the description !

@javierjulio javierjulio changed the title Improve french translation Improve French translation Mar 13, 2023
Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cprodhomme no worries, thank you so much! I'll get this in once build passes as I rebased.

@javierjulio javierjulio merged commit 7f56ccf into activeadmin:master Mar 13, 2023
@cprodhomme cprodhomme deleted the patch-1 branch March 14, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants