Chmod delete #63
Merged
Chmod delete #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YiMysty
approved these changes
Jun 15, 2023
1 task
JamesMGreene
added a commit
that referenced
this pull request
Jul 10, 2023
JamesMGreene
added a commit
that referenced
this pull request
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of: https://github.com/github/pages-engineering/issues/2428
Removing
chmodsince it tends to slow down deploys. Instead we going to trust by default that the user will have correct file permissions. If this is not the case then we will raise an error from our deployment side and flag file permissions as being a possible culprit.