-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include fs stats and mode in zip archive, fix "too many open files" error #1723
base: main
Are you sure you want to change the base?
Include fs stats and mode in zip archive, fix "too many open files" error #1723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the right one that works for me unless you know it works for me good so zip hope you figure the problem that you got going on read read you get it
actions/upload-artifact#485 looks relevant here, and could be easily fixed in the same PR by using |
Commit 5f62f1e should fix actions/upload-artifact#485. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looking at file documentation this PR should fix actions/upload-artifact#485
@bethanyj28 - It looks like you've been doing recent work on the |
@SrRyan @yacaovsnc You recently reviewed PRs touching this part of the code (#1678 and #1724 respectively). Could you take a look at this PR? It's intended to fix the seventh-most-upvoted issue in actions/upload-artifact and also a recent issue that prevents uploaded artifacts from containing more than about 8,000 files. The latter has a workaround, using If you're not the right people to contact about code review, would you let me know whom I should be talking to? Thank you. |
This should allow Unix file permissions to be included in the zip file created by upload-artifact, fixing actions/upload-artifact#38 and probably actions/upload-artifact#37 as well.
Fixes #1722.
Fixes actions/upload-artifact#485.
This is basically #1609, rebased against the current state of the
main
branch. But #1609 did not include themode
property in its call tozip.append
, and my research suggests thatmode
is needed to actually include the permissions in the zip file.