Action doesn't fail on invalid credentials

[neykov]

Description:
Upon configuring the action with invalid credentials it reports a successful completion even though it wasn't able to connect.

Starting the stale action process...
Error: Get issues for repo error: Bad credentials
No more issues found to process. Exiting...
Statistics:
Operations performed: 1

Action version:
6.0.1

Platform:

• Ubuntu
• macOS
• Windows

Runner type:

• Hosted
• Self-hosted

Repro steps:

• Configure the action as usual
• Provide invalid repo-token

Expected behavior:
The job should fail, along with the whole action execution.

Actual behavior:
The job successfully completes, even though it's not able to connect.

[dsame]

hello @neykov, thanks for your input. We started to investigate the issue

[dsame]

The #935 merged into the main and will be included it next release.

[panticmilos]

hi @neykov, we have released a new major version that is addressing this issue.

Could you confirm it is working as expected?

[neykov]

@panticmilos thanks for the fix. I tested it and it's failing as expected now. Here's the output:

Starting the stale action process...
Error: Error: Getting issues was blocked by the error: Bad credentials
Error: Getting issues was blocked by the error: Bad credentials