Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme refers to old version of actions/checkout #755

Closed
Julian-O opened this issue Oct 28, 2023 · 7 comments
Closed

Readme refers to old version of actions/checkout #755

Julian-O opened this issue Oct 28, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@Julian-O
Copy link

Julian-O commented Oct 28, 2023

Description:

The Readme documentation references actions/checkout@v3.
The latest version is actions/checkout@v4.

Action version:
Latest readme

Platform:

  • N/A

Runner type:

  • N/A

Tools version:

  • N/A

Repro steps:

  • N/A

Expected behavior:
Should model ideal behaviour - using the latest version.

Actual behavior:
Has out-dated reference.

@Julian-O Julian-O added bug Something isn't working needs triage labels Oct 28, 2023
@dmitry-shibanov
Copy link
Contributor

Hello @Julian-O. Thank you for your report. We'll take a look on it.

@kurtmckee
Copy link
Contributor

kurtmckee commented Oct 31, 2023

Multiple PRs have been filed to address this; each varies slightly, but I recommend merging #727 because it addresses many more cases in more files than the others.

#727, #729, #738

@Julian-O
Copy link
Author

@kurtmckee: Thanks. While all of those look worthy, only #738 actually tackles this particular issue.

@kurtmckee
Copy link
Contributor

#738 is highly targeted and doesn't touch other files that also need to be updated (such as the actual workflow files that execute).

I've updated my recommendation, above, to #727 because it addresses many more cases, including the README.

@Julian-O
Copy link
Author

Julian-O commented Nov 1, 2023

@kurtmckee: I apologise. I looked at 727 on my phone, and thought it didn't update README. I see now it does. No need for 738 if you approve 727.

@kurtmckee
Copy link
Contributor

No apology needed! We're both contributing our time as we can and making recommendations to the actions/setup-python maintainers. 👍

@dmitry-shibanov
Copy link
Contributor

Hello everyone. We've updated the documentation. For now I'm going to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants