Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions prefixed with == fail to be found when not in the local cache #711

Closed
4 of 5 tasks
Harmon758 opened this issue Aug 3, 2023 · 4 comments
Closed
4 of 5 tasks
Assignees
Labels
bug Something isn't working

Comments

@Harmon758
Copy link

Description:
When a version is prefixed with == and is not found in the local cache, it fails to be found for downloading.

I encountered this while specifying the version through project.requires-python in pyproject.toml.
I'm not sure if python-version also has this issue, but I presume so.

Action version:
v4.7.0

Platforms:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:
Every Python version not in the local cache

Repro steps:
I was originally using python-version: ['3.10.10'], which successfully downloads.
Upon changing to use python-version-file: pyproject.toml with requires-python = "==3.10.10" (under [project]) in pyproject.toml, the version fails to be found.

Additionally, I confirmed that this is only an issue when the version is not found in the local cache, as removing the patch version in pyproject.toml and changing it to requires-python = "==3.10" successfully installs the version in the local cache.

Expected behavior:
The version is successfully downloaded and installed

Actual behavior:
The version fails to be found

@Harmon758 Harmon758 added bug Something isn't working needs triage labels Aug 3, 2023
@dmitry-shibanov
Copy link
Contributor

Hello @Harmon758. Thank you for your report. We will take a look at the issue.

@dmitry-shibanov
Copy link
Contributor

Hello @Harmon758. Could you please try to use actions/setup-python@main?

@dmitry-shibanov
Copy link
Contributor

Hello @Harmon758. The new version of the action was released and the major tag was updated. For now I'm going to close the issue.

@Harmon758
Copy link
Author

Apologies for the delay in testing out the fix.
I can confirm now though that #726 has resolved the issue after updating to v4.7.1.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants