Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraalPy support #693

Closed
timfel opened this issue Jun 27, 2023 · 8 comments · Fixed by #694
Closed

Add GraalPy support #693

timfel opened this issue Jun 27, 2023 · 8 comments · Fixed by #694
Labels
feature request New feature or request to improve the current logic needs eyes

Comments

@timfel
Copy link
Contributor

timfel commented Jun 27, 2023

Description:
I would like to add support for installing GraalPy via setup-python. We are starting to ask people to include support for GraalPy in their packages, and they (reasonably) request to be able to test against GraalPy using their existing workflows using setup-python.

Are you willing to submit a PR?
I have prepared the changes for setup-python, mimicking the PyPy support code. The tests using local mock data pass.

@timfel timfel added feature request New feature or request to improve the current logic needs triage labels Jun 27, 2023
@timfel timfel mentioned this issue Jun 28, 2023
2 tasks
@dmitry-shibanov
Copy link
Contributor

Hello @timfel. Thank you for your feature request. We'll investigate it.

@timfel
Copy link
Contributor Author

timfel commented Jun 28, 2023

Hello @timfel. Thank you for your feature request. We'll investigate it.

Thanks. I opened a PR to implement this at #694

@dusan-trickovic dusan-trickovic linked a pull request Jul 13, 2023 that will close this issue
2 tasks
@dusan-trickovic dusan-trickovic removed a link to a pull request Jul 13, 2023
2 tasks
@dusan-trickovic dusan-trickovic linked a pull request Jul 13, 2023 that will close this issue
2 tasks
@dmitry-shibanov
Copy link
Contributor

Hello @timfel. We've merged the pull request. Could you please try to use actions/setup-python@main and confirm that it works as expected for you. For now I'm going to reopen the issue until the new version of action is released.

@timfel
Copy link
Contributor Author

timfel commented Oct 11, 2023

Thanks @dmitry-shibanov. I tried it and it it works as expected

@kurtmckee
Copy link
Contributor

I tested this using the following configuration:

- uses: "actions/setup-python@v5"
  with:
    python-version: |
      graalpy-23.1
      pypy-3.10
      3.11

Link to run, which failed on Windows

For Linux and macOS, graalpy-23.1 resolved to version 23.1.1.

However, on Windows, setup-python reported that no "23.1" version existed:

Run actions/setup-python@v5
  with:
    python-version: graalpy-23.1
  pypy-3.10
  3.11
  
    check-latest: false
    token: ***
    update-environment: true
    allow-prereleases: false
Installed versions
  GraalPy version 23.1 was not found in the local cache
  Error: GraalPy version 23.1 with arch x64 not found

This is the complete list of files for the GraalPy 23.1.1 release at the time of writing:

graalpy-23.1.1-linux-aarch64.tar.gz
graalpy-23.1.1-linux-aarch64.tar.gz.sha256
graalpy-23.1.1-linux-amd64.tar.gz
graalpy-23.1.1-linux-amd64.tar.gz.sha256
graalpy-23.1.1-macos-aarch64.tar.gz
graalpy-23.1.1-macos-aarch64.tar.gz.sha256
graalpy-23.1.1-macos-amd64.tar.gz
graalpy-23.1.1-macos-amd64.tar.gz.sha256
graalpy-23.1.1-windows-amd64.zip
graalpy-23.1.1-windows-amd64.zip.sha256
graalpy-community-23.1.1-linux-aarch64.tar.gz
graalpy-community-23.1.1-linux-aarch64.tar.gz.sha256
graalpy-community-23.1.1-linux-amd64.tar.gz
graalpy-community-23.1.1-linux-amd64.tar.gz.sha256
graalpy-community-23.1.1-macos-aarch64.tar.gz
graalpy-community-23.1.1-macos-aarch64.tar.gz.sha256
graalpy-community-23.1.1-macos-amd64.tar.gz
graalpy-community-23.1.1-macos-amd64.tar.gz.sha256
graalpy-community-jvm-23.1.1-linux-aarch64.tar.gz
graalpy-community-jvm-23.1.1-linux-aarch64.tar.gz.sha256
graalpy-community-jvm-23.1.1-linux-amd64.tar.gz
graalpy-community-jvm-23.1.1-linux-amd64.tar.gz.sha256
graalpy-community-jvm-23.1.1-macos-aarch64.tar.gz
graalpy-community-jvm-23.1.1-macos-aarch64.tar.gz.sha256
graalpy-community-jvm-23.1.1-macos-amd64.tar.gz
graalpy-community-jvm-23.1.1-macos-amd64.tar.gz.sha256
graalpy-jvm-23.1.1-linux-aarch64.tar.gz
graalpy-jvm-23.1.1-linux-aarch64.tar.gz.sha256
graalpy-jvm-23.1.1-linux-amd64.tar.gz
graalpy-jvm-23.1.1-linux-amd64.tar.gz.sha256
graalpy-jvm-23.1.1-macos-aarch64.tar.gz
graalpy-jvm-23.1.1-macos-aarch64.tar.gz.sha256
graalpy-jvm-23.1.1-macos-amd64.tar.gz
graalpy-jvm-23.1.1-macos-amd64.tar.gz.sha256
graalpy-jvm-23.1.1-windows-amd64.zip
graalpy-jvm-23.1.1-windows-amd64.zip.sha256

It appears that there is an x64-compatible Windows release available, and I expected this to result in GraalPy getting installed for Windows.

Is this perhaps an issue with Windows releases using .zip as their file extension?

@timfel
Copy link
Contributor Author

timfel commented Dec 11, 2023

@kurtmckee The windows support of graalpy 23.1 is highly experimental, so we excluded it on purpose. The 24 release due out April 24 will improve the situation at which point we'll update the action

@kurtmckee
Copy link
Contributor

Okay, thanks for the quick response!

@dmitry-shibanov
Copy link
Contributor

Hello everyone. For now I'm going to close the issue because the support for GraalPy was released in 4.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic needs eyes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants