Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching Python version from Pipenv's Pipfile #574

Open
kalrish opened this issue Dec 24, 2022 · 4 comments
Open

Fetching Python version from Pipenv's Pipfile #574

kalrish opened this issue Dec 24, 2022 · 4 comments
Labels
feature request New feature or request to improve the current logic

Comments

@kalrish
Copy link

kalrish commented Dec 24, 2022

Description:
The Python version to set up may be specified with the input python-version-file. As I submit this feature request, this input expects a file containing only the Python version, as used by pyenv. I propose that the feature be extended to support the TOML key requires.python_version in Pipenv's Pipfile.

#542 has been submitted as a similar request for pyproject.toml, another file in TOML format.

Justification:
Dependencies of Python apps not meant to be distributed are often managed with Pipenv, which is developed and maintained by the Python Packaging Authority (PyPA) and their documented tool. Pipenv allows to specify the oldest Python version the app requires in the Pipfile.

The action setup-node, too, can load the Node.js version to set up from a variety of files. It, however, supports not just files containing only the Node.js version, like .nvmrc and .node_version, but also the structured format of package.json.

Are you willing to submit a PR?
Yes, I am. If you want me to contribute the described functionality, please let me know of any preferences regarding TOML libraries.

@kalrish kalrish added feature request New feature or request to improve the current logic needs triage labels Dec 24, 2022
@MaksimZhukov
Copy link
Contributor

Hello @kalrish! Thank you for reporting this!
We'll consider updating the parsing logic for the python-version-file input.

@kalrish
Copy link
Author

kalrish commented Dec 30, 2022

Thank you, @MaksimZhukov. If you decide to accept this feature, I would be glad to implement it for you, or at least try. In any case, I wish you a good start into the new year :). Take care!

@Crono1981
Copy link

This would be a most welcome addition.

@WieeRd
Copy link

WieeRd commented Jan 15, 2024

Similar to this, pyproject.toml support would be also nice.
The project.requires-python key contains Python version requirement.

[project]
requires-python = ">=3.11"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

4 participants