Add support for .tool-versions file in setup-python #1043
Merged
+193
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
Whatsapp.web/id-ID.com |
priya-kinthali
approved these changes
Mar 11, 2025
aparnajyothi-y
approved these changes
Mar 12, 2025
HarithaVattikuti
approved these changes
Mar 13, 2025
2 tasks
This was referenced Mar 21, 2025
aparnajyothi-y
pushed a commit
that referenced
this pull request
Apr 1, 2025
* add support for .tool-versions file * update regex * optimize code * update test-python.yml for .tool-versions * fix format-check errors * fix formatting in test-python.yml * Fix test-python.yml error * workflow update with latest versions * update test cases * fix lint issue
mahabaleshwars
added a commit
that referenced
this pull request
Apr 3, 2025
* add support for .tool-versions file * update regex * optimize code * update test-python.yml for .tool-versions * fix format-check errors * fix formatting in test-python.yml * Fix test-python.yml error * workflow update with latest versions * update test cases * fix lint issue
1 task
hjpotter92
reviewed
Apr 4, 2025
| if (line.trim().startsWith('#')) { | ||
| continue; | ||
| } | ||
| const match = line.match(/^\s*python\s*v?\s*(?<version>[^\s]+)\s*$/); |
There was a problem hiding this comment.
minor nit: the [^\s] can be replaced with just \S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added support for .tool-versions file in setup-python. It can be passed through python-version-file.
Related issue:
#970
Check list: