Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support volta.extends in node-version-file #920

Closed
ThisIsManta opened this issue Dec 15, 2023 · 2 comments
Closed

Support volta.extends in node-version-file #920

ThisIsManta opened this issue Dec 15, 2023 · 2 comments
Assignees
Labels
feature request New feature or request to improve the current logic

Comments

@ThisIsManta
Copy link
Contributor

ThisIsManta commented Dec 15, 2023

Description:

Given the repository containing the below files

// package.json
{ "volta": { "node": "20.0.0" } }

and

// e2e/package.json
{ "volta": { "extends": "../package.json" } }

When the action is called with...

      - uses: actions/setup-node@v4
        with:
          node-version-file: e2e/package.json

Then it should result in Node.js v20.0.0 because this is how Volta works: https://docs.volta.sh/advanced/workspaces

But instead, I got the below error:
image

Justification:
If setup-node action claim to support Volta, then this extends field should be read and resolve into a concrete value of Node.js version as well.

Are you willing to submit a PR?
Yes, here you are: #921

@ThisIsManta ThisIsManta added feature request New feature or request to improve the current logic needs triage labels Dec 15, 2023
@aparnajyothi-y
Copy link
Contributor

Hello @ThisIsManta. Thank for a feature request. We will investigate it and share our results.

@ThisIsManta
Copy link
Contributor Author

The PR has been merged. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

2 participants