Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --frozen-lockfile for pnpm deps installation in document #725

Closed
SnO2WMaN opened this issue Mar 23, 2023 · 3 comments
Closed

Remove --frozen-lockfile for pnpm deps installation in document #725

SnO2WMaN opened this issue Mar 23, 2023 · 3 comments
Assignees
Labels
feature request New feature or request to improve the current logic

Comments

@SnO2WMaN
Copy link

Description:

In below documents pnpm install --frozen-lockfile, but pnpm passes the --frozen-lockfile option automatically when it detects that it is running on CI (i.e. on GitHub Actions).

**Caching pnpm (v6.10+) dependencies:**
```yaml
# This workflow uses actions that are not certified by GitHub.
# They are provided by a third-party and are governed by
# separate terms of service, privacy policy, and support
# documentation.
# NOTE: pnpm caching support requires pnpm version >= 6.10.0
steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
with:
version: 6.32.9
- uses: actions/setup-node@v3
with:
node-version: '14'
cache: 'pnpm'
- run: pnpm install --frozen-lockfile
- run: pnpm test
```

I thought it seems that it is better not to pass it explicitly in document, so as not to cause unnecessary confusion.

References

Are you willing to submit a PR?

Yes

@SnO2WMaN SnO2WMaN added feature request New feature or request to improve the current logic needs triage labels Mar 23, 2023
@dmitry-shibanov
Copy link
Contributor

Hello @SnO2WMaN. Thank you for your suggestion. Do these changes apply to pnpm 6.10+ versions ?

@SnO2WMaN
Copy link
Author

Hello @SnO2WMaN. Thank you for your suggestion. Do these changes apply to pnpm 6.10+ versions ?

At least works in pnpm v7, and perhaps even works in v6.

@dmitry-shibanov
Copy link
Contributor

Hello @SnO2WMaN. I'm going to close the feature request because we've updated the documentation in scope of this pull request: #789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

2 participants