Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Action template has wrong syntax for Go version #387

Closed
4 of 5 tasks
metalim opened this issue Jun 18, 2023 · 2 comments
Closed
4 of 5 tasks

Go Action template has wrong syntax for Go version #387

metalim opened this issue Jun 18, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@metalim
Copy link

metalim commented Jun 18, 2023

Description:
Go Action template contains wrong syntax for Go version, without quotes. If user adjusts just the number, it could lead to wrong Go version being used.
Extract of this issue, as the cause was not resolved: #380 (comment)

Action version:
v4.0.1 (latest)

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:
1.20

Repro steps:

  1. In Actions: choose [New Workflow]
image
  1. choose Go, Configure
image
  1. observe wrong format is used for version, without quotes:
image
  1. note, that at this point you don't have README at hand, and don't know about the upcoming issue, if you change version to 1.20

Expected behavior:
Template should contain version in quotes

Actual behavior:
Template contains version without quotes

@metalim metalim added bug Something isn't working needs triage labels Jun 18, 2023
@dmitry-shibanov
Copy link
Contributor

Hello @metalim. Thank you for your report. We'll take a look at it.

@dmitry-shibanov
Copy link
Contributor

Hello @metalim. The template was updated. For now I'm going to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants