Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 20 versions prior to Node 20.11 had a bug that caused a crash when accessing files with emojis in their names. #3263

Open
kzrnm opened this issue Apr 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kzrnm
Copy link

kzrnm commented Apr 27, 2024

Describe the bug

Node 20 on Windows prior to Node 20.11 had a bug that caused it to crash when accessing a file with an emoji in its name.

The current runner uses 20.8.1 and is affected by this bug.

NODE20_VERSION="20.8.1"

To Reproduce

name: Python
on:
  workflow_dispatch:
jobs:
  download:
    strategy:
      matrix:
        os: [ubuntu-latest, windows-latest, macos-latest]
        python:
          - "3.9"
      fail-fast: false

    runs-on: ${{ matrix.os }}
    steps:
      - run: |
          touch "👍.txt"
          touch requirements.txt
      - name: Set up Python
        uses: actions/setup-python@v5
        with:
          python-version: "${{ matrix.python }}"
          cache: pip

Expected behavior

All strategies are successfully completed.

Actual behavior:

On windows,

Runner Version and Platform

  • windows-2022

What's not working?

Job Log Output

Error: Cannot read properties of undefined (reading '0')
node:internal/fs/promises:894
  const result = await binding.stat(pathModule.toNamespacedPath(path),
                               ^
Error: ENOENT: no such file or directory, stat
    at Object.stat (node:internal/fs/promises:894:32)
    at DefaultGlobber.<anonymous> (D:\a\_actions\actions\setup-python\v5\dist\setup\index.js:7081:47)
    at Generator.next (<anonymous>)
    at D:\a\_actions\actions\setup-python\v5\dist\setup\index.js:6911:71
    at new Promise (<anonymous>)
    at __webpack_modules__.8298.__awaiter (D:\a\_actions\actions\setup-python\v5\dist\setup\index.js:6907:12)
    at DefaultGlobber.stat (D:\a\_actions\actions\setup-python\v5\dist\setup\index.js:7073:16)
    at DefaultGlobber.globGenerator_1 (D:\a\_actions\actions\setup-python\v5\dist\setup\index.js:7018:60)
    at globGenerator_1.next (<anonymous>)
    at resume (D:\a\_actions\actions\setup-python\v5\dist\setup\index.js:6927:44) {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'stat'
}

Simple example repository

https://github.com/kzrnm/emoji-file-action/tree/simple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant