Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub CLI to 2.49.0 in Ubuntu 22.04 (current ubuntu-latest) #9784

Closed
3 of 14 tasks
matthewfeickert opened this issue May 3, 2024 · 6 comments
Closed
3 of 14 tasks
Assignees
Labels
Area: Scripting and command line awaiting-deployment Code complete; awaiting deployment and/or deployment in progress feature request OS: Ubuntu

Comments

@matthewfeickert
Copy link

matthewfeickert commented May 3, 2024

Tool name

GitHub CLI

Tool license

MIT

Add or update?

  • Add
  • Update

Desired version

2.49.0

Approximate size

No response

Brief description of tool

No response

URL for tool's homepage

https://github.com/cli/cli

Provide a basic test case to validate the tool's functionality.

gh attestation verify --help

Platforms where you need the tool

  • Azure DevOps
  • GitHub Actions

Runner images where you need the tool

  • Ubuntu 20.04
  • Ubuntu 22.04
  • macOS 11
  • macOS 12
  • macOS 13
  • macOS 13 Arm64
  • macOS 14
  • macOS 14 Arm64
  • Windows Server 2019
  • Windows Server 2022

Can this tool be installed during the build?

I think so, but this wouldn't be the recommended approach.

Tool installation time in runtime

No response

Are you willing to submit a PR?

Yes, though it unclear from PRs like PR #9730 how to actually do this for the GitHub CLI.

@matthewfeickert
Copy link
Author

matthewfeickert commented May 3, 2024

In PR #9776, the ubuntu-24.04 runner environment description was added, which includes

This is great, but for using gh attestation verify to validate a GitHub artifact attestation before publishing to an index or repository in a GitHub Actions workflow (c.f. scikit-hep/pyhf#2473)

    - name: Verify wheel artifact attestation
      env:
        GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      run: gh attestation verify dist/package-*.whl --repo ${{ github.repository }}

this now requires users to switch to ubuntu-24.04. As ubuntu-22.04 is the current ubuntu-latest runner, it would be useful to update

to 2.49.0 there as well.

@sssharif
Copy link
Contributor

sssharif commented May 3, 2024

thank you for your request. GitHub CLI will be updated in next image deployment. We expect next image deployment will be on tuesday or wednesday next week.

@cclauss
Copy link

cclauss commented May 7, 2024

@matthewfeickert
Copy link
Author

matthewfeickert commented May 9, 2024

We expect next image deployment will be on tuesday or wednesday next week.

@sssharif @shamil-mubarakshin Do you have an updated estimate on this?

@mikhailkoliada
Copy link
Member

Deployed

@matthewfeickert
Copy link
Author

Thank you @mikhailkoliada!

For others, c.f. https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240514.2 for the full deployment notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Scripting and command line awaiting-deployment Code complete; awaiting deployment and/or deployment in progress feature request OS: Ubuntu
Projects
None yet
Development

No branches or pull requests

6 participants