Node version upgrade to 20 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: MaksimZhukov <46996400+MaksimZhukov@users.noreply.github.com>
src/api-utils.ts
Outdated
Comment on lines
17
to
19
| interface Error { | ||
| status?: number; | ||
| } |
There was a problem hiding this comment.
I think it will be better to change it to this:
interface ErrorStatus extends Error {
status: number;
}because TypeScript already has interface Error.
There was a problem hiding this comment.
Implemented the change
dmitry-shibanov
approved these changes
Dec 5, 2023
MaksimZhukov
approved these changes
Dec 6, 2023
IvanZosimov
approved these changes
Dec 6, 2023
| @@ -14,19 +14,23 @@ interface GitRef { | |||
| }; | |||
| } | |||
|
|
|||
| interface ErrorStatus extends Error { | |||
| status?: number; | |||
There was a problem hiding this comment.
Just a minor comment and please correct me if I'm wrong, but I think we can also remove the question mark here now that the suggested change has been implemented?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes added for the node-version upgrade to node20.
Related issue:
Feature Request