Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain misconfigured workflow #405

Merged
merged 1 commit into from Jun 19, 2023
Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jul 25, 2022

Labeler has a bunch of more or less related problems.

The general implementation to address this fits the outlines in #136 (comment)

https://github.com/check-spelling/use-labeler/actions/runs/2729552526
image

Annotations
1 error and 1 warning
label
Resource not accessible by integration
⚠️ jsoref/labeler running under 'pull_request' is misconfigured
It needs permissions: pull-requests: write to work. Update the workflow. See https://github.com/actions/labeler/blob/6a315d4ea58951035b498eef56668feaba24489f/README.md#create-workflow


https://github.com/check-spelling/use-labeler/runs/7492560360?check_suite_focus=true

Run jsoref/labeler@main
Workflow is not configured to label forks, exiting

This could include an info item, but, I don't really see the point.


@jsoref jsoref requested a review from a team as a code owner July 25, 2022 02:57
@jsoref
Copy link
Contributor Author

jsoref commented Aug 7, 2022

@pje: is there something I need to do to push this along?

@jsoref
Copy link
Contributor Author

jsoref commented Aug 22, 2022

@thboop? I understand you're busy, but it'd be really helpful if someone would look (I can, of course, resolve conflicts, but it isn't worth it if no one will look at the PR.)

@ofek
Copy link

ofek commented Sep 13, 2022

Is it possible to split the fixes into separate PRs? I don't think it'll be reviewed otherwise.

@jsoref
Copy link
Contributor Author

jsoref commented Sep 13, 2022

@ofek: it isn't worth my time to do such a thing until a GitHub employee shows that they're willing to actually review things. This project appears to be entirely orphaned. @ethomson prove me wrong.

To your question: the commits are distinct and anyone w/ write permissions could trivially cherry-pick them individually.

@Yaminyam
Copy link

It is considered a very serious error to unintentionally delete a label in a tool for automating labeling.
I think that PR should be reflected quickly.

@ford-at-aws
Copy link

👋 From AWS! We rely on this labeling solution and would love to see this bug worked out. Thanks!

@jsoref
Copy link
Contributor Author

jsoref commented Sep 30, 2022

@ford-at-aws I've enabled github actions on my fork: https://github.com/jsoref/labeler/actions -- and I've merged the changes into it.

Actions details for the relevant commits

Merge pull request #1 from jsoref/fix-labeler
Build & Test #2: Commit 3cc0b12 pushed by jsoref
main

Fix labeler
Build & Test #1: Pull request jsoref#1 opened by jsoref
fix-labeler

image
Switching from actions/labeler@v4.0.1 to jsoref/labeler@v0-5.0.0

In theory where you would have used actions/labeler@v4.0.1, you could use jsoref/labeler@v0-5.0.0.
Or where you could have used actions/labeler@e54e5b338fbd6e6cdb5d60f51c22335fc57c401e, you could use actions/labeler@6b5f93ed5fc722246dd157acf1984bb1e3065b4d.

I will not delete the above tag. I can't delete the above commit sha -- do note that the sha doesn't (at the present time) refer to a commit in this repository, it's just jsoref@6b5f93e, but by referencing this repository, you should be less sensitive to me renaming my repository (which I don't intend to ever do).

Updated 2022-12-20

Switching from actions/labeler@v4.0.2 to jsoref/labeler@v0-5.0.1

In theory where you would have used actions/labeler@v4.0.2, you could use jsoref/labeler@v0-5.0.1.
Or where you could have used actions/labeler@5c7539237e04b714afd8ad9b4aed733815b9fab4, you could use actions/labeler@c6732c9ca7d4d449e8d513bbd5be7900a2461cff.

I will not delete the above tag. I can't delete the above commit sha -- do note that the sha doesn't (at the present time) refer to a commit in this repository, it's just jsoref@c6732c9, but by referencing this repository, you should be less sensitive to me renaming my repository (which I don't intend to ever do).

@efb4f5ff-1298-471a-8973-3d47447115dc

Hi @jsoref do you think my issue #442 is related?

@jsoref
Copy link
Contributor Author

jsoref commented Oct 3, 2022

@efb4f5ff-1298-471a-8973-3d47447115dc: dunno. I don't suppose you'd be willing to try using the labeler as versioned in #405 (comment) for a bit? I imagine you'd be able to confirm its behavior pretty quickly... You could even create a second copy (not really a fork, just a copy) of your repository w/ the alternate labeler and see how it behaves...

@jsoref
Copy link
Contributor Author

jsoref commented Dec 20, 2022

@MaksimZhukov can you look at this PR as well? At least one linked repository has been using this for months.

@Pkanjai
Copy link

Pkanjai commented Apr 13, 2023

65535

@AndreiLobanovich AndreiLobanovich self-assigned this Jun 13, 2023
Copy link
Contributor

@AndreiLobanovich AndreiLobanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @jsoref,

Thank you for your efforts and the time you have spent on creating this pull request. We appreciate contributors like you who are willing to dedicate their time to improving this project.
Some of the issues you are fixing have already been addressed in other pull requests:

  1. The action.yml file is now properly annotated.
  2. The issue with the sync-labels input has already been fixed in the new major release as it is a breaking change

After reviewing your PR we came to the conclusion that we want to accept the change regarding the warning (the one I left comment for). Other changes are unnecessary.
We greatly appreciate your contribution and your patience through this process. We hope that this explanation provides clarity on our current position, and we certainly welcome future contributions from you.

src/labeler.ts Outdated Show resolved Hide resolved
@jsoref jsoref changed the title Fix labeler Explain misconfigured workflow Jun 13, 2023
@MaksimZhukov MaksimZhukov merged commit b5ff161 into actions:main Jun 19, 2023
7 checks passed
@MaksimZhukov
Copy link
Contributor

@jsoref thank you for the contribution!

@jsoref jsoref deleted the fix-labeler branch June 19, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants