Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array with all property #266

Closed
Waltari10 opened this issue Oct 26, 2021 · 3 comments
Closed

Array with all property #266

Waltari10 opened this issue Oct 26, 2021 · 3 comments
Labels
duplicate This issue or pull request already exists question Further information is requested

Comments

@Waltari10
Copy link

Waltari10 commented Oct 26, 2021

I'm trying to add a label to PR:s only if certain files have changed.

I tried the following:

# Automatically exclude changes from release notes
ignore-for-release:
  - all: ['**/*.spec.ts', '**/*.md', '**/*.test.ts', '.github/**.*', '.vscode/**.*']

However it seems this never triggers.

Basically I would like ANY globs to match against ALL changed paths. 🤔

For example, if there are changes to ".md" files and ".github/**" files I would like it to add "ignore-for-release" tag.

But if there are change to ".md" files, ".github/**" files AND ".tsx" files then I don't want it to add the label.

Is this possible with the current feature set?

@tkbeal
Copy link

tkbeal commented Jan 31, 2022

I'm also new to this action, but I think your current config will fire when all the files changed match your match object, which is not what you want. I think you maybe should put the OR logic into top-level list and add an all to your label match and see if that works.

ignore-for-release:
- '.github/**/*'
- '**/*.md'
- '**/*.test.ts'
- all: ['!**/*.tsx']

@MaksimZhukov MaksimZhukov added the question Further information is requested label Dec 12, 2022
@dfandrich
Copy link
Contributor

This looks like a dupe of #423.

@MaksimZhukov
Copy link
Contributor

Hello @Waltari10!
Unfortunately, this functionality is not available at the moment. We are considering adding it to a new major release.
I am closing this issue. Please track the progress of this feature request in scope of this issue.

@MaksimZhukov MaksimZhukov added the duplicate This issue or pull request already exists label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants
@dfandrich @Waltari10 @tkbeal @MaksimZhukov and others