Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking: Support Node 20 #421

Closed
3 tasks done
joshmgross opened this issue Sep 27, 2023 · 5 comments
Closed
3 tasks done

Tracking: Support Node 20 #421

joshmgross opened this issue Sep 27, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@joshmgross
Copy link
Member

joshmgross commented Sep 27, 2023 •
edited

Actions now supports Node 20 - https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

We should release a new version of this action that uses Node 20 and drop unnecessary dependencies such as node-fetch. Since this will be a breaking change, we should also update any other dependencies to their latest versions such as @actions/github.
@joshmgross joshmgross added the enhancement New feature or request label Sep 27, 2023
@joshmgross joshmgross mentioned this issue Sep 27, 2023
Closed
@MikeMcC399
Copy link

@joshmgross

It will be good to have a new node20 version as the blog you linked to says that starting Oct 23, 2023 node16 JavaScript Actions will begin generating deprecation warnings.

@MikeMcC399 MikeMcC399 mentioned this issue Oct 11, 2023
Closed
@timogasda
Copy link

@joshmgross Would be great to leave NodeJS 16 behind soon. Is there any kind of ETA for this fix? Would any contributions help?

@MikeMcC399
Copy link

There is a note in actions/upload-artifact#444 (comment) from @joshmgross which says that GitHub is coordinating this update for official GitHub actions, so it's still a Work-In-Progress.

@joshmgross
Copy link
Member Author

No ETA at the moment, but it's something we plan to do soon.

#425 (comment) is blocking the upgrade right now, I haven't had time to identify what is breaking the previews input for preview headers. External contributions are welcome if you'd like to look into that.

rimrul added a commit to rimrul/rss-issues-action that referenced this issue Nov 3, 2023
@rimrul
ci: use actions/checkout@v4
3e2be6f 
now that the rss-to-issues action uses node 20, it's time to update the
actions we use for our CI jobs, to also use node 20.
actions/checkout@v2 in verify-dist.yml was so old that GitHub was forcing
it to run under node 16 insted of node 12 which it was designed to run
under.

actions/github-script does not support node 20 yet, though. [1]

[1] actions/github-script#421

Signed-off-by: Matthias Aßhauer <mha1993@live.de>
@joshmgross joshmgross mentioned this issue Nov 9, 2023
Merged
dscho added a commit to dscho/get-azure-pipelines-artifact that referenced this issue Nov 13, 2023
@dscho
ci: use actions/checkout@v4
4593955 
Now that this Action uses node.js 20, it's time to update the
actions we use for our CI jobs, to also use node.js 20.

actions/github-script does not support node.js 20 yet, though. [1]

[1] actions/github-script#421

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@joshmgross
Copy link
Member Author

Released as part of https://github.com/actions/github-script/releases/tag/v7.0.0

@timogasda timogasda mentioned this issue Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timogasda @joshmgross @MikeMcC399