Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove circular JSON references for error debugging #197

Merged
merged 1 commit into from Jul 10, 2023
Merged

Remove circular JSON references for error debugging #197

merged 1 commit into from Jul 10, 2023

Conversation

JamesMGreene
Copy link
Contributor

Closes #158

Towards:

Debugging errors is a nice idea, but not helpful for HttpErrors that contain circular references that make the action throw an error instead. 馃槄

Let's just remove it for cleanliness. 馃Ч

@JamesMGreene JamesMGreene requested a review from a team as a code owner July 10, 2023 20:00
@JamesMGreene JamesMGreene merged commit a562022 into main Jul 10, 2023
6 checks passed
@JamesMGreene JamesMGreene deleted the break-the-circle branch July 10, 2023 20:03
@JamesMGreene JamesMGreene mentioned this pull request Jul 10, 2023
Open
@anibe anibe mentioned this pull request Jul 20, 2023
Closed
JamesMGreene added a commit that referenced this pull request Aug 9, 2023
@JamesMGreene
Backporting PR #197 to the v1.x release line
f27bcc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YiMysty YiMysty YiMysty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Converting circular structure to JSON
2 participants
@JamesMGreene @YiMysty