Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ensure GitHub Action Dependencies are Pinned #633

Open
wadells opened this issue Dec 4, 2023 · 1 comment
Open

Feature Request: Ensure GitHub Action Dependencies are Pinned #633

wadells opened this issue Dec 4, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@wadells
Copy link

wadells commented Dec 4, 2023

The GitHub Actions documentation on "Using 3rd Party Actions" states that users should:

Pin actions to a full length commit SHA

Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. When selecting a SHA, you should verify it is from the action's repository and not a repository fork.

However, GitHub does not currently provide a way for users to enforce this guideline when new GitHub Actions are added to a repository. Instead, users are turning to 3rd party actions like the following:

https://github.com/zgosalvez/github-actions-ensure-sha-pinned-actions

At Teleport, we already use dependency review to look for security and license issues in incoming dependencies. I'd also like dependency-review-action to have a way to enforce that dependencies are pinned. I care about this feature for GitHub Actions more than my other ecosystems (go, javascript, terraform) because those ecosystems have lock files built into the dependency management toolchain.

@febuiles febuiles added the enhancement New feature or request label Dec 5, 2023
@febuiles
Copy link
Contributor

febuiles commented Dec 5, 2023

@wadells thank you for taking the time to share your ideas.

I think this would be a nice thing to have, maybe added as a config option (another one 😅) to maintain support with existing users. I've tagged it and hopefully can get to this at some point in the future. If you want to open a pull request I'd be more than happy to help out getting this out quicker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants