Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshots warnings for NPM projects #566

Closed
louis-bompart opened this issue Sep 13, 2023 · 2 comments
Closed

Snapshots warnings for NPM projects #566

louis-bompart opened this issue Sep 13, 2023 · 2 comments

Comments

@louis-bompart
Copy link

Hi there 馃憢 Since the release of v3.1.0, we noticed that the action is now reporting a warning about missing snapshots

I reckon NodeJS/NPM is one of the "statically defined dependencies in one of GitHub鈥檚 supported ecosystems", and thus do not need to submit those snapshots.

Am I missing something? What should we do to remove this warning from our JS projects?
@febuiles febuiles mentioned this issue Sep 14, 2023
Open
1 task
@febuiles
Copy link
Contributor

@louis-bompart Thanks for raising this issue. I've created #567 to keep track of general improvements we need to make to the new snapshots feature, and I'll update you here once we have improved the current situation.

@febuiles febuiles mentioned this issue Nov 24, 2023
Closed
@febuiles
Copy link
Contributor

@louis-bompart closing this in favor of #567, which contains more details and centralized another conversation. Your input would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@febuiles @louis-bompart