Improve display of snapshot warnings #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tons of people are going to be getting these warnings, so I wanted to make sure they're as helpful as they can be. That means advising people about the most obvious solutions given the particular situation they're in. Usually that means telling them to make sure snapshots are submitted for PR branches and/or to enable
retry-on-snapshot-warnings, depending on the context.I apologize for the lack of tests, but we don't really have the mocking facilities we'd need to really test this effectively. FWIW, I've spent this morning trying this out manually in a test repo (
dsp-testing/dr-snaps-d).