Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty PURLs should not block the action from running #494

Merged
merged 4 commits into from May 31, 2023
Merged

Empty PURLs should not block the action from running #494

merged 4 commits into from May 31, 2023

Conversation

febuiles
Copy link
Contributor

Fixes #493.

@febuiles febuiles requested a review from a team as a code owner May 31, 2023 14:26
theztefan
theztefan approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@theztefan theztefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the #493.

It will still fail when the package_url is not a valid purl string, but given we get this information from Dependancy Graph (API) this should not happen/be possible.

@febuiles febuiles merged commit 1360a34 into main May 31, 2023
4 checks passed
@Abuchtela Abuchtela mentioned this pull request Sep 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theztefan theztefan theztefan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A purl string argument is required.
2 participants
@febuiles @theztefan