Skip to content

feat!: remove deprecated inputs #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 3, 2025
Merged

Conversation

parkerbxyz
Copy link
Contributor

@parkerbxyz parkerbxyz commented Mar 20, 2025

BREAKING CHANGE: Removed deprecated inputs (app_id, private_key, skip_token_revoke) and made app-id and private-key required in the action configuration.

Updates to required fields and removal of deprecated inputs:

  • action.yml: Made app-id and private-key required and removed the deprecated app_id and private_key inputs.
  • main.js: Updated the code to only use app-id and private-key inputs, removing the fallback to deprecated inputs.
  • Removed the deprecated skip_token_revoke input.

Test file updates:

Unverified

The email in this signature doesn’t match the committer email.

Unverified

The email in this signature doesn’t match the committer email.
@parkerbxyz parkerbxyz self-assigned this Mar 20, 2025
@parkerbxyz parkerbxyz requested a review from a team as a code owner March 20, 2025 05:44
@parkerbxyz parkerbxyz marked this pull request as draft March 20, 2025 05:45
@parkerbxyz parkerbxyz added this to the v2 milestone Mar 20, 2025

Unverified

The email in this signature doesn’t match the committer email.
@parkerbxyz parkerbxyz force-pushed the remove-deprecated-inputs branch from 096bd76 to dd64f6e Compare April 3, 2025 18:49

Unverified

The email in this signature doesn’t match the committer email.

Unverified

The email in this signature doesn’t match the committer email.
@parkerbxyz parkerbxyz marked this pull request as ready for review April 3, 2025 18:59

Unverified

The email in this signature doesn’t match the committer email.
@parkerbxyz parkerbxyz merged commit 5cc811b into main Apr 3, 2025
4 checks passed
@parkerbxyz parkerbxyz deleted the remove-deprecated-inputs branch April 3, 2025 19:10
create-app-token-action-releaser bot pushed a commit that referenced this pull request Apr 3, 2025

Unverified

The email in this signature doesn’t match the committer email.
# [2.0.0](v1.12.0...v2.0.0) (2025-04-03)

* feat!: remove deprecated inputs ([#213](#213)) ([5cc811b](5cc811b))

### BREAKING CHANGES

* Removed deprecated inputs (`app_id`, `private_key`, `skip_token_revoke`) and made `app-id` and `private-key` required in the action configuration.
@create-app-token-action-releaser

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Yang-33 added a commit to Yang-33/create-github-app-token that referenced this pull request Apr 4, 2025

Unverified

The email in this signature doesn’t match the committer email.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants