Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant API call #175

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Conversation

parkerbxyz
Copy link
Contributor

Combines the two installation requests (org and user) into one because /org/{org} can also be accessed at /users/{org}.

parkerbxyz and others added 3 commits October 4, 2024 15:27

Verified

This commit was signed with the committer’s verified signature.
parkerbxyz Parker Brown
We can combine these two requests into one because `/org/{org}` can also be accessed at `/users/{org}`.

Co-Authored-By: Gregor Martynus <39992+gr2m@users.noreply.github.com>

Verified

This commit was signed with the committer’s verified signature.
parkerbxyz Parker Brown

Verified

This commit was signed with the committer’s verified signature.
parkerbxyz Parker Brown
@parkerbxyz parkerbxyz requested review from gr2m and a team as code owners October 4, 2024 22:51
@parkerbxyz parkerbxyz marked this pull request as draft October 4, 2024 23:05
@parkerbxyz
Copy link
Contributor Author

Converting to draft to recondider test file names.

Verified

This commit was signed with the committer’s verified signature.
parkerbxyz Parker Brown
@parkerbxyz parkerbxyz marked this pull request as ready for review October 7, 2024 19:52
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also cleaning up the existing tests 👍🏼

@gr2m gr2m merged commit 25cc3bd into main Oct 7, 2024
4 checks passed
@gr2m gr2m deleted the use-users-endpoint-for-orgs-too branch October 7, 2024 20:26
@parkerbxyz parkerbxyz self-assigned this Nov 14, 2024
@create-app-token-action-releaser

🎉 This PR is included in version 1.11.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@EronWright
Copy link

@parkerbxyz should the REST API documentation be updated to this effect? That FindUserInstallation works with organizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants