Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nextjs images.unoptimized config path name #33

Closed
wants to merge 4 commits into from

Conversation

TheKojuEffect
Copy link
Contributor

images.unoptimized is stable with NextJS v12.3.0.

https://nextjs.org/docs/api-reference/next/image#unoptimized

`images.unoptimized` is no longer in `experimental` and is stable with NextJS `v12.3.0`.
https://nextjs.org/docs/api-reference/next/image#unoptimized
@TheKojuEffect TheKojuEffect requested a review from a team as a code owner October 25, 2022 03:10
@@ -34,7 +34,8 @@ function getConfigParserSettings({ staticSiteGenerator, generatorConfigFile, sit

// Disable server side image optimization too
// https://nextjs.org/docs/api-reference/next/image#unoptimized
'experimental.images.unoptimized': true
'experimental.images.unoptimized': true,
'images.unoptimized': true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping both to support old and new NextJS versions.

Copy link
Contributor

@JamesMGreene JamesMGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems totally reasonable. Thank you for the contribution! 💝

src/set-pages-config.js Show resolved Hide resolved
@JamesMGreene JamesMGreene mentioned this pull request Nov 18, 2022
auto-merge was automatically disabled November 18, 2022 07:01

Pull request was closed

JamesMGreene added a commit that referenced this pull request Nov 18, 2022
@TheKojuEffect TheKojuEffect deleted the patch-1 branch November 18, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants