From 693e9eb54328978edc069b6984b6ad908df1d15f Mon Sep 17 00:00:00 2001 From: Cory Miller <13227161+cory-miller@users.noreply.github.com> Date: Thu, 10 Nov 2022 15:34:24 -0500 Subject: [PATCH 1/3] test with ubuntu/squid --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 0e77c5741..c28e77194 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -142,7 +142,7 @@ jobs: options: --dns 127.0.0.1 services: squid-proxy: - image: datadog/squid:latest + image: ubuntu/squid:latest ports: - 3128:3128 env: From 2cc55f98cdf16c2b9e4ec35ac705bc9202a8e2fe Mon Sep 17 00:00:00 2001 From: Cory Miller <13227161+cory-miller@users.noreply.github.com> Date: Thu, 10 Nov 2022 15:39:42 -0500 Subject: [PATCH 2/3] Start a contributing guide --- CONTRIBUTING.md | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 000000000..56508e0f1 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,28 @@ +# Contributing + +## Submitting a pull request + +1. Fork and clone the repository +1. Configure and install the dependencies: `npm install` +1. Create a new branch: `git checkout -b my-branch-name` +1. Make your change, add tests, and make sure the tests still pass: `npm run test` +1. Make sure your code is correctly formatted: `npm run format` +1. Update `dist/index.js` using `npm run build`. This creates a single javascript file that is used as an entrypoint for the action +1. Push to your fork and [submit a pull request][pr] +1. Pat yourself on the back and wait for your pull request to be reviewed and merged. + +Here are a few things you can do that will increase the likelihood of your pull request being accepted: + +- Write tests. +- Keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests. + +## Resources + +- [How to Contribute to Open Source](https://opensource.guide/how-to-contribute/) +- [Using Pull Requests](https://help.github.com/articles/about-pull-requests/) +- [GitHub Help](https://help.github.com) +- [Writing good commit messages](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) + +Thanks! :heart: :heart: :heart: + +GitHub Actions Team :octocat: From f7d98a91c59d36a67abcc5e475dd01a21be2a6fe Mon Sep 17 00:00:00 2001 From: Cory Miller <13227161+cory-miller@users.noreply.github.com> Date: Thu, 10 Nov 2022 15:53:05 -0500 Subject: [PATCH 3/3] remove link --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 56508e0f1..5c7646519 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -8,8 +8,8 @@ 1. Make your change, add tests, and make sure the tests still pass: `npm run test` 1. Make sure your code is correctly formatted: `npm run format` 1. Update `dist/index.js` using `npm run build`. This creates a single javascript file that is used as an entrypoint for the action -1. Push to your fork and [submit a pull request][pr] -1. Pat yourself on the back and wait for your pull request to be reviewed and merged. +1. Push to your fork and submit a pull request +1. Pat yourself on the back and wait for your pull request to be reviewed and merged Here are a few things you can do that will increase the likelihood of your pull request being accepted: