-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Permission is missing in cache delete example #1123
Merged
kotewar
merged 1 commit into
actions:main
from
kotokaze:fix/add-missing-permmision-to-delete
Feb 27, 2023
Merged
Bug: Permission is missing in cache delete example #1123
kotewar
merged 1 commit into
actions:main
from
kotokaze:fix/add-missing-permmision-to-delete
Feb 27, 2023
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotewar
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed PR description. LGTM.
dapirian
referenced
this pull request
in trunk-io/plugins
Mar 9, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/cache](https://togithub.com/actions/cache) | action | minor | `v3.2.4` -> `v3.3.0` | | [github/codeql-action](https://togithub.com/github/codeql-action) | action | patch | `v2.2.3` -> `v2.2.5` | | [trunk-io/trunk-action](https://togithub.com/trunk-io/trunk-action) | action | patch | `v1.0.6` -> `v1.0.7` | --- ### Release Notes <details> <summary>actions/cache</summary> ### [`v3.3.0`](https://togithub.com/actions/cache/releases/tag/v3.3.0) [Compare Source](https://togithub.com/actions/cache/compare/v3.2.6...v3.3.0) #### What's Changed - Bug: Permission is missing in cache delete example by [@​kotokaze](https://togithub.com/kotokaze) in [https://github.com/actions/cache/pull/1123](https://togithub.com/actions/cache/pull/1123) - Add `lookup-only` option by [@​cdce8p](https://togithub.com/cdce8p) in [https://github.com/actions/cache/pull/1041](https://togithub.com/actions/cache/pull/1041) #### New Contributors - [@​kotokaze](https://togithub.com/kotokaze) made their first contribution in [https://github.com/actions/cache/pull/1123](https://togithub.com/actions/cache/pull/1123) **Full Changelog**: actions/cache@v3...v3.3.0 ### [`v3.2.6`](https://togithub.com/actions/cache/releases/tag/v3.2.6) [Compare Source](https://togithub.com/actions/cache/compare/v3.2.5...v3.2.6) ##### What's Changed - Updated branch in Force deletion of caches by [@​t-dedah](https://togithub.com/t-dedah) in [https://github.com/actions/cache/pull/1108](https://togithub.com/actions/cache/pull/1108) - Fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners by [@​pdotl](https://togithub.com/pdotl) in [https://github.com/actions/cache/pull/1118](https://togithub.com/actions/cache/pull/1118) **Full Changelog**: actions/cache@v3...v3.2.6 ### [`v3.2.5`](https://togithub.com/actions/cache/releases/tag/v3.2.5) [Compare Source](https://togithub.com/actions/cache/compare/v3.2.4...v3.2.5) ##### What's Changed - Rewrite readmes by [@​jsoref](https://togithub.com/jsoref) in [https://github.com/actions/cache/pull/1085](https://togithub.com/actions/cache/pull/1085) - Fixed typos and formatting in docs by [@​kotewar](https://togithub.com/kotewar) in [https://github.com/actions/cache/pull/1076](https://togithub.com/actions/cache/pull/1076) - Fixing paths for OSes by [@​kotewar](https://togithub.com/kotewar) in [https://github.com/actions/cache/pull/1101](https://togithub.com/actions/cache/pull/1101) - Release patch version update by [@​Phantsure](https://togithub.com/Phantsure) in [https://github.com/actions/cache/pull/1105](https://togithub.com/actions/cache/pull/1105) ##### New Contributors - [@​jsoref](https://togithub.com/jsoref) made their first contribution in [https://github.com/actions/cache/pull/1085](https://togithub.com/actions/cache/pull/1085) **Full Changelog**: actions/cache@v3...v3.2.5 </details> <details> <summary>github/codeql-action</summary> ### [`v2.2.5`](https://togithub.com/github/codeql-action/compare/v2.2.4...v2.2.5) [Compare Source](https://togithub.com/github/codeql-action/compare/v2.2.4...v2.2.5) ### [`v2.2.4`](https://togithub.com/github/codeql-action/compare/v2.2.3...v2.2.4) [Compare Source](https://togithub.com/github/codeql-action/compare/v2.2.3...v2.2.4) </details> <details> <summary>trunk-io/trunk-action</summary> ### [`v1.0.7`](https://togithub.com/trunk-io/trunk-action/releases/tag/v1.0.7) [Compare Source](https://togithub.com/trunk-io/trunk-action/compare/v1.0.6...v1.0.7) Introduce a caching-only mode, controlled via `check-mode: populate_cache_only`. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/trunk-io/plugins). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTkuMiIsInVwZGF0ZWRJblZlciI6IjM0LjE1OS4yIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
This was referenced Jun 24, 2023
kayman-mk
referenced
this pull request
in Hapag-Lloyd/terraform-aws-bastion-host-ssm
Nov 23, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/cache](https://togithub.com/actions/cache) | action | minor | `v3.2.5` -> `v3.3.2` | --- ### Release Notes <details> <summary>actions/cache (actions/cache)</summary> ### [`v3.3.2`](https://togithub.com/actions/cache/releases/tag/v3.3.2) [Compare Source](https://togithub.com/actions/cache/compare/v3.3.1...v3.3.2) ##### What's Changed - Fixed readme with new segment timeout values by [@​kotewar](https://togithub.com/kotewar) in [https://github.com/actions/cache/pull/1133](https://togithub.com/actions/cache/pull/1133) - Readme fixes by [@​kotewar](https://togithub.com/kotewar) in [https://github.com/actions/cache/pull/1134](https://togithub.com/actions/cache/pull/1134) - Updated description of the lookup-only input for main action by [@​kotewar](https://togithub.com/kotewar) in [https://github.com/actions/cache/pull/1130](https://togithub.com/actions/cache/pull/1130) - Change two new actions mention as quoted text by [@​bishal-pdMSFT](https://togithub.com/bishal-pdMSFT) in [https://github.com/actions/cache/pull/1131](https://togithub.com/actions/cache/pull/1131) - Update Cross-OS Caching tips by [@​pdotl](https://togithub.com/pdotl) in [https://github.com/actions/cache/pull/1122](https://togithub.com/actions/cache/pull/1122) - Bazel example (Take [#​2](https://togithub.com/actions/cache/issues/2)️⃣) by [@​vorburger](https://togithub.com/vorburger) in [https://github.com/actions/cache/pull/1132](https://togithub.com/actions/cache/pull/1132) - Remove actions to add new PRs and issues to a project board by [@​jorendorff](https://togithub.com/jorendorff) in [https://github.com/actions/cache/pull/1187](https://togithub.com/actions/cache/pull/1187) - Consume latest toolkit and fix dangling promise bug by [@​chkimes](https://togithub.com/chkimes) in [https://github.com/actions/cache/pull/1217](https://togithub.com/actions/cache/pull/1217) - Bump action version to 3.3.2 by [@​bethanyj28](https://togithub.com/bethanyj28) in [https://github.com/actions/cache/pull/1236](https://togithub.com/actions/cache/pull/1236) ##### New Contributors - [@​vorburger](https://togithub.com/vorburger) made their first contribution in [https://github.com/actions/cache/pull/1132](https://togithub.com/actions/cache/pull/1132) - [@​jorendorff](https://togithub.com/jorendorff) made their first contribution in [https://github.com/actions/cache/pull/1187](https://togithub.com/actions/cache/pull/1187) - [@​chkimes](https://togithub.com/chkimes) made their first contribution in [https://github.com/actions/cache/pull/1217](https://togithub.com/actions/cache/pull/1217) - [@​bethanyj28](https://togithub.com/bethanyj28) made their first contribution in [https://github.com/actions/cache/pull/1236](https://togithub.com/actions/cache/pull/1236) **Full Changelog**: actions/cache@v3...v3.3.2 ### [`v3.3.1`](https://togithub.com/actions/cache/releases/tag/v3.3.1) [Compare Source](https://togithub.com/actions/cache/compare/v3.3.0...v3.3.1) ##### What's Changed - Reduced download segment size to 128 MB and timeout to 10 minutes by [@​kotewar](https://togithub.com/kotewar) in [https://github.com/actions/cache/pull/1129](https://togithub.com/actions/cache/pull/1129) **Full Changelog**: actions/cache@v3...v3.3.1 ### [`v3.3.0`](https://togithub.com/actions/cache/releases/tag/v3.3.0) [Compare Source](https://togithub.com/actions/cache/compare/v3.2.6...v3.3.0) ##### What's Changed - Bug: Permission is missing in cache delete example by [@​kotokaze](https://togithub.com/kotokaze) in [https://github.com/actions/cache/pull/1123](https://togithub.com/actions/cache/pull/1123) - Add `lookup-only` option by [@​cdce8p](https://togithub.com/cdce8p) in [https://github.com/actions/cache/pull/1041](https://togithub.com/actions/cache/pull/1041) ##### New Contributors - [@​kotokaze](https://togithub.com/kotokaze) made their first contribution in [https://github.com/actions/cache/pull/1123](https://togithub.com/actions/cache/pull/1123) **Full Changelog**: actions/cache@v3...v3.3.0 ### [`v3.2.6`](https://togithub.com/actions/cache/releases/tag/v3.2.6) [Compare Source](https://togithub.com/actions/cache/compare/v3.2.5...v3.2.6) ##### What's Changed - Updated branch in Force deletion of caches by [@​t-dedah](https://togithub.com/t-dedah) in [https://github.com/actions/cache/pull/1108](https://togithub.com/actions/cache/pull/1108) - Fix zstd not being used after zstd version upgrade to 1.5.4 on hosted runners by [@​pdotl](https://togithub.com/pdotl) in [https://github.com/actions/cache/pull/1118](https://togithub.com/actions/cache/pull/1118) **Full Changelog**: actions/cache@v3...v3.2.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Hapag-Lloyd/terraform-aws-bastion-host-ssm). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Jan 22, 2024
Dakshjain1
pushed a commit
to SvavaCapital/cache
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add permission to delete cache with
gh-actions-cache
Description
According to the API documentation,
actions:write
permission is at least required.( Referred to https://docs.github.com/en/rest/actions/cache?apiVersion=2022-11-28#delete-a-github-actions-cache-for-a-repository-using-a-cache-id )
Motivation and Context
My action based on the example has failed to delete with

ERROR: Resource not accessible by integration
.Log: https://github.com/kotokaze/texlive/actions/runs/4272709474/jobs/7438088882
How Has This Been Tested?
The action deleted caches as expected by adding
actions:write
permissionLog: https://github.com/kotokaze/texlive/actions/runs/4273085511/jobs/7438755085
Types of changes
Checklist: