Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOBREPOSITORY does not respect repo name changes #3412

Open
4 tasks done
ahatzz11 opened this issue Apr 7, 2024 · 1 comment
Open
4 tasks done

JOBREPOSITORY does not respect repo name changes #3412

ahatzz11 opened this issue Apr 7, 2024 · 1 comment
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers

Comments

@ahatzz11
Copy link

ahatzz11 commented Apr 7, 2024

Checks

Controller Version

0.9.0

Deployment Method

ArgoCD

Checks

  • This isn't a question or user support case (For Q&A and community support, go to Discussions).
  • I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

  1. Create a repository, e.g. multi-service
  2. Rename the repository, e.g. platform-core-services
  3. Run a job and inspect the ephemeralrunners - kubectl get ephemeralrunners
  4. See the JOBREPOSITORY is using the original repository name instead of the new name.

Describe the bug

I noticed when looking at what jobs were actively running on our runners with kubectl get ephemeralrunners that there were repo names that I didn't recognize in the JOBREPOSITORY field. Upon further inspection it is because this field is using an original name of the repository instead of the current name of the repository. For a specific example we have a repository in our org called platform-core-services. The original repo name was multi-service, and this is what is being reported:

» kubectl get ephemeralrunners

NAME                                       GITHUB CONFIG URL        RUNNERID   STATUS    JOBREPOSITORY                JOBWORKFLOWREF                                 WORKFLOWRUNID   JOBDISPLAYNAME                    MESSAGE   AGE
custom-linux-standard-wt56w-runner-82bwm   https://github.com/ORG   1456071    Running   ORG/multi-service            ORG/workflows/gradle-build.yaml@refs/tags/v0   8578405827      gradle-build / build                        83s

If I navigate to github.com/ORG/multi-service it properly redirects to github.com/ORG/platform-core-services, but looking at this output and JOBREPOSITORY is a bit weird.

Describe the expected behavior

I would expect that the JOBREPOSITORY field on ephemeralrunners shows the current name of a repository and not the original name.

Additional Context

I'm happy to provide any values.yaml or logs if needed but there isn't anything in logs or our configuration that seems to show the issue or define this setting. Looking at the output of kubectl get ephemeralrunners is where the issue presents itself.

N/A

Controller Logs

N/A

Runner Pod Logs

N/A
@ahatzz11 ahatzz11 added bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers labels Apr 7, 2024
Copy link
Contributor

github-actions bot commented Apr 7, 2024

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers
Projects
None yet
Development

No branches or pull requests

1 participant