-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When starting gha-runner-scale-set in "dind" mode, I would like to be able to change the Dockerd settings in the Pod using the values.yaml. #3403
Comments
Hello! Thank you for filing an issue. The maintainers will triage your issue shortly. In the meantime, please take a look at the troubleshooting guide for bug reports. If this is a feature request, please review our contribution guidelines. |
I need to modify dockerd args on dind container, turns out it is not templated and is hardcoded directly at actions-runner-controller/charts/gha-runner-scale-set/templates/_helpers.tpl Lines 98 to 116 in 1987d9e
|
cc @nikola-jokic. This issue is labeled I am not even sure if this is a feature request or a bug because is this intended or something that need to be addressed? I see that there's also PR related to this issue: #3394 |
Hey everyone, @Hazmi35 you are right, this one is for the gha-runner-scale-set. That being said, we documented that:
It should be easy since we documented the exact setup in values.yaml file that would be used for that container mode. I will close this issue here. |
What would you like added?
When gha-runner-scale-set is started in "dind" mode, I would like to be able to change the proxy settings and insecure-registry settings for Dockerd on the Pod from values.yaml.
Why is this needed?
When starting gha-runner-scale-set in "dind" mode behind a proxy server, it was not possible to retrieve container images from the internet when running GitHub Actions workflows.
Additionally, it was not possible to retrieve images from container registries with self-certificates applied.
If I modify the settings of "gha-runner-scale-set.dind-container" appropriately, it will behave as expected.
I would like to be able to change proxy settings and insecure-registry settings without having to perform these workarounds.
Actually, I modified the following parts and started gha-runner-scale-set.
◆Added "HTTP_PROXY", "HTTPS_PROXY" and "NO_PROXY"
https://github.com/actions/actions-runner-controller/blob/master/charts/gha-runner-scale-set/templates/_helpers.tpl#L104-L106
◆Mount ConfigMap to "/etc/docker/daemon.json"
https://github.com/actions/actions-runner-controller/blob/master/charts/gha-runner-scale-set/templates/_helpers.tpl#L109-L115
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: