Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

grcov v0.5.14 broke the --output-file option #70

Closed
rye opened this issue May 11, 2020 · 1 comment · Fixed by #71
Closed

grcov v0.5.14 broke the --output-file option #70

rye opened this issue May 11, 2020 · 1 comment · Fixed by #71
Labels
bug Something isn't working

Comments

@rye
Copy link
Contributor

rye commented May 11, 2020

After v0.5.14 of grcov was released, actions-rs/grcov invocations stopped working because the --output-file command-line option is no longer recognized by the grcov binary.

Looking at the compare, (upstream does not keep a proper changelog) it appears that mozilla/grcov@26acaa0 is the culprit, and does not include a backwards compatibility mechanism. It appears that a simple change from output-file to output-path is all that is necessary to resolve this, and I'm preparing a patch for that. This issue is mostly just for tracking.

@rye rye added the bug Something isn't working label May 11, 2020
@rye rye changed the title grcov v0.5.14 broke the output-file option grcov v0.5.14 broke the --output-file option May 11, 2020
rye added a commit to rye/grcov that referenced this issue May 11, 2020
This change is necessary to fix the problems mentioned in actions-rs#70.

In short, `--output-file` was renamed to `--output-path` with no
backwards compatibility mechanism.  The semantics are the same.  See
also [1].

[1]: mozilla/grcov@26acaa0

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
svartalf pushed a commit that referenced this issue May 12, 2020
* buildArgs: Replace --output-file with --output-path

This change is necessary to fix the problems mentioned in #70.

In short, `--output-file` was renamed to `--output-path` with no
backwards compatibility mechanism.  The semantics are the same.  See
also [1].

[1]: mozilla/grcov@26acaa0

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
@svartalf
Copy link
Member

Thank you for the patch, published in v0.1.6 tag and available via the actions-rs/grcov@v0.1 tag!

dacut added a commit to dacut/scratchstack-aws-signature that referenced this issue Jun 8, 2020
JelteF added a commit to JelteF/example-rust that referenced this issue Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants