feat!: return null from bytestream when stream closes #158
+72
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 96.88% 96.97% +0.08%
==========================================
Files 107 107
Lines 9761 9782 +21
Branches 1474 1482 +8
==========================================
+ Hits 9457 9486 +29
+ Misses 304 296 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
achingbrain
force-pushed
the
fix/re-throw-error-on-write
branch
from
bc679f6 to
fcb6ab1
Compare
If a required number of bytes is not specified, and the underlying stream closes without yielding any bytes, return `null` instead of throwing `EOF`. BREAKING CHANGE: if the underlying stream closes without yielding any bytes and we are not waiting for a required number of bytes, `byteStream.read` will now return `null` instead of an empty `Uint8ArrayList`
achingbrain
force-pushed
the
fix/return-null-from-closed-bytestream
branch
from
2b87067 to
db1b24e
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
## [it-byte-stream-v2.0.0](it-byte-stream-1.1.1...it-byte-stream-2.0.0) (2025-03-19) ### ⚠ BREAKING CHANGES * if the underlying stream closes without yielding any bytes and we are not waiting for a required number of bytes, `byteStream.read` will now return `null` instead of an empty `Uint8ArrayList` * the `AbortOptions` interface is no longer exported, use the one from `abort-error` instead ### Features * return null from bytestream when stream closes ([#158](#158)) ([df88a9d](df88a9d)) ### Bug Fixes * remove AbortOptions exports ([#156](#156)) ([34b18fb](34b18fb))
|
🎉 This PR is included in version it-byte-stream-v2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
## [it-length-prefixed-stream-v2.0.0](it-length-prefixed-stream-1.2.1...it-length-prefixed-stream-2.0.0) (2025-03-19) ### ⚠ BREAKING CHANGES * if the underlying stream closes without yielding any bytes and we are not waiting for a required number of bytes, `byteStream.read` will now return `null` instead of an empty `Uint8ArrayList` * the `AbortOptions` interface is no longer exported, use the one from `abort-error` instead ### Features * return null from bytestream when stream closes ([#158](#158)) ([df88a9d](df88a9d)) ### Bug Fixes * remove AbortOptions exports ([#156](#156)) ([34b18fb](34b18fb))
|
🎉 This PR is included in version it-length-prefixed-stream-v2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a required number of bytes is not specified, and the underlying stream closes without yielding any bytes, return
nullinstead of throwingEOF.BREAKING CHANGE: if the underlying stream closes without yielding any bytes and we are not waiting for a required number of bytes,
byteStream.readwill now returnnullinstead of an emptyUint8ArrayList