Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add debug messages for exclusions during bump lifecycle #131

Merged

Conversation

SchulteMarkus
Copy link

Code has been modified to include debug messages in the bump lifecycle. When a filename is ignored by Git or is not a file, the program will now log a debug-level message.

Code has been modified to include debug messages in the bump lifecycle. When a filename is ignored by Git or is not a file, the program will now log a debug-level message.
@SchulteMarkus
Copy link
Author

SchulteMarkus commented Mar 8, 2024

I had a wrong gitignore file. These debug outputs would have helped me to identify the cause more quickly.
While this change would have helped, I'd like to ask:
Why shouldn't you bump the bumpFiles if they are in the gitignore? Updating the bumpFiles does no harm, gitignore takes over the task of not committing unwanted files.

@TimothyJones TimothyJones changed the title chore: Add debug messages for exclusions in lifecycle bump fix: Add debug messages for exclusions in lifecycle bump Mar 31, 2024
@TimothyJones TimothyJones changed the title fix: Add debug messages for exclusions in lifecycle bump fix: Add debug messages for exclusions during bump lifecycle Mar 31, 2024
Copy link
Member

@TimothyJones TimothyJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this! Sorry it took so long to get to it - I missed the notification somehow.

Looks good to me (with a couple suggestions left inline).

At the moment, the format check is failing so I can't merge it in. I would normally just fix this for you, but I'm travelling at the moment.

If you can push a commit that runs the formatter (just do npm run format:fix), I'd be happy to merge it. Otherwise, I'll do it when I'm back on deck in a week or two.

Thanks again!

lib/lifecycles/bump.js Outdated Show resolved Hide resolved
lib/lifecycles/bump.js Outdated Show resolved Hide resolved
@SchulteMarkus
Copy link
Author

I like to contribute something if I can.
Thanks for the feedback, I've adjusted the code accordingly.

@TimothyJones TimothyJones enabled auto-merge (squash) April 19, 2024 03:41
@TimothyJones TimothyJones merged commit a9191f2 into absolute-version:master Apr 19, 2024
8 checks passed
ixuz pushed a commit to ixuz/commit-and-tag-version that referenced this pull request Apr 19, 2024
…e-version#131)

* chore: Add debug messages for exclusions in lifecycle bump

Code has been modified to include debug messages in the bump lifecycle. When a filename is ignored by Git or is not a file, the program will now log a debug-level message.

* chore(absolute-version#131): Update formatting

* chore(absolute-version#131): Improve debug messages for exclusions during bump lifecycle
TimothyJones added a commit that referenced this pull request Apr 19, 2024
* test: add openapi crlf mocks

* test: add openapi lf mocks

* feat: add support for openapi version bumping (almost identical to yaml-updater)

* test: OpenAPI updater tests

* fix: Add debug messages for exclusions during bump lifecycle (#131)

* chore: Add debug messages for exclusions in lifecycle bump

Code has been modified to include debug messages in the bump lifecycle. When a filename is ignored by Git or is not a file, the program will now log a debug-level message.

* chore(#131): Update formatting

* chore(#131): Improve debug messages for exclusions during bump lifecycle

* chore(master): release 12.3.0 (#139)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* docs: add documentation about how to bump OpenAPI version

---------

Co-authored-by: Markus Schulte <mail@schulte-development.de>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Timothy Jones <timothy.l.jones@gmail.com>
@SchulteMarkus SchulteMarkus deleted the chore/debug-bump-exclusions branch April 22, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants