Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use standard schema ending # #113

Merged
merged 1 commit into from Oct 12, 2023

Conversation

henryiii
Copy link
Collaborator

Fixes #111. Added a test that ensures the old ones are still accepted.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@abravalheri
Copy link
Owner

This looks good. Thank you very much for taking the time to investigate that and provide the fix.

Just to clarify things, fastjsonschema does not need an exact match when using referenced schemas right? (i.e. the "parent" schema can be http://.../draft-07/schema# and the "referenced" schema can be https://.../draft-07/schema, right?)

@henryiii
Copy link
Collaborator Author

I think so, but I'd have to set up a test to be sure. (Though I know you can't use https for 7 and below). I'd doubt it matters, though as fastjsonschema doesn't seem to care much about this value, you can literally set it to anything.

@abravalheri
Copy link
Owner

Thank you very much @HenryII.
I will think about a test in a follow up.

@abravalheri abravalheri merged commit 13dd0ef into abravalheri:main Oct 12, 2023
29 checks passed
@henryiii henryiii deleted the henryiii/fix/schemaending branch October 12, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Schema string is inconsistent (no trailing #)
2 participants