Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix README: Llama3VisionAlpha not Llama3VisionAlphaChatHandler #1488

Closed
mdnestor opened this issue May 26, 2024 · 1 comment
Closed

Fix README: Llama3VisionAlpha not Llama3VisionAlphaChatHandler #1488

mdnestor opened this issue May 26, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mdnestor
Copy link

mdnestor commented May 26, 2024 •
edited
Loading

Under "Multi-modal Models", README.md says to use Llama3VisionAlphaChatHandler. However in llama_cpp/llama_chat_format.py we see the correct name is Llama3VisionAlpha.
@abetlen
Copy link
Owner

abetlen commented May 27, 2024 •
edited
Loading

@mdnestor thanks for catching that, though it's technically a breaking change I may rename the chat handler and add an alias to it if someone runs into an issue. I'll update the name in llama_chat_format and alias the old name to it.

@abetlen abetlen added the bug Something isn't working label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abetlen @mdnestor