Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HtmlProcessingInstruction type missing #28

Closed
eliotwrobson opened this issue Feb 2, 2024 · 1 comment
Closed

HtmlProcessingInstruction type missing #28

eliotwrobson opened this issue Feb 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@eliotwrobson
Copy link

See title. There's no type annotation for HtmlProcessingInstruction (just a comment here: https://github.com/abelcheung/types-lxml/blob/main/lxml-stubs/html/_element.pyi#L228).

This class seems to be supported by lxml, and the project I'm working on uses this in our test cases (see PrairieLearn/PrairieLearn#9356 (comment)). I think the annotation for this should be added back to the stubs here.
@abelcheung
Copy link
Owner

It's fine for me, just that I'm really surprised it's actually been used. Will create a release after this change.

@abelcheung abelcheung added the bug Something isn't working label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abelcheung @eliotwrobson