Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation should only be published after a release #179

Closed
mdbenito opened this issue Oct 26, 2022 · 5 comments · Fixed by #352
Closed

Documentation should only be published after a release #179

mdbenito opened this issue Oct 26, 2022 · 5 comments · Fixed by #352
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@mdbenito
Copy link
Collaborator

It seems like GH pages are rebuilt from develop. This would be ok if one could switch versions like in readthedocs, but as it is, the docs document features not in the pypi package.

Either we offer both the stable and the development version or we limit the public pages to the released version

@mdbenito mdbenito added bug Something isn't working documentation Improvements or additions to documentation labels Oct 26, 2022
@mdbenito
Copy link
Collaborator Author

@AnesBenmerzoug maybe it's better to switch to read the docs and have multiple versions online?

@AnesBenmerzoug
Copy link
Collaborator

@mdbenito I agree. A switch to readthedocs seems like it would make our lives easier.

Do we already have an account for that?

@mdbenito
Copy link
Collaborator Author

mdbenito commented Nov 6, 2022

Not that I know of. I thought kyle might use RTD but I couldn't even find any built docs for it (no links to docs and.. OMG NO BADGES!! 😱).

So I guess we can create an account. We might want to pay for private docs too, we'll discuss on Monday.

@mdbenito mdbenito changed the title documentation should only be published after a release Documentation should only be published after a release Dec 1, 2022
@mdbenito
Copy link
Collaborator Author

In case someone wants to work on this, I made some tweaks for RTD (untested) in https://github.com/appliedAI-Initiative/pyDVL/tree/feature/rtd

@mdbenito
Copy link
Collaborator Author

mdbenito commented Jan 14, 2023

Instead of read the docs, we can just publish to subfolders inside gh-pages and use a custom dropdown to select among them. At the root we leave the latest stable release.

Also see:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants