Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new release needed: posting from a split workflow fails with error #117

Closed
BenWibking opened this issue Mar 15, 2024 · 2 comments · Fixed by quokka-astro/quokka#567
Closed

new release needed: posting from a split workflow fails with error #117

BenWibking opened this issue Mar 15, 2024 · 2 comments · Fixed by quokka-astro/quokka#567

Comments

@BenWibking
Copy link

Posting the review comments from a split workflow fails with the error:

Traceback (most recent call last):
Attempting to automatically download review artifacts
  File "/usr/local/bin/post", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/usr/local/lib/python3.[12](https://github.com/quokka-astro/quokka/actions/runs/8300661163/job/22719069742#step:3:13)/site-packages/clang_tidy_review/post.py", line 80, in main
    metadata, review = download_artifacts(pull_request, int(args.workflow_id))
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/clang_tidy_review/__init__.py", line 929, in download_artifacts
    "GET", artifact.archive_download_url, headers=pull.headers("json")
                                                  ^^^^^^^^^^^^
AttributeError: 'PullRequest' object has no attribute 'headers'

See https://github.com/quokka-astro/quokka/actions/runs/8300661163/job/22719069742
@BenWibking
Copy link
Author

It looks like this was fixed in #115, but there hasn't been a release yet that incorporates this fix. Can one of the project admins make a new release?

@BenWibking BenWibking changed the title posting from a split workflow fails with error new release needed: posting from a split workflow fails with error Mar 17, 2024
BenWibking added a commit to quokka-astro/quokka that referenced this issue Mar 17, 2024
@BenWibking
Fix clang-tidy-review comment posting
912884a 
This updates the clang-tidy-review comment-posting action in order to fix ZedThree/clang-tidy-review#117.
@BenWibking BenWibking mentioned this issue Mar 17, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit to quokka-astro/quokka that referenced this issue Mar 18, 2024
@BenWibking
Fix clang-tidy-review comment posting (#567)
3f39068 
### Description
This updates the clang-tidy-review comment-posting action in order to
fix ZedThree/clang-tidy-review#117.

### Related issues
ZedThree/clang-tidy-review#117

### Checklist
_Before this pull request can be reviewed, all of these tasks should be
completed. Denote completed tasks with an `x` inside the square brackets
`[ ]` in the Markdown source below:_
- [x] I have added a description (see above).
- [x] I have added a link to any related issues see (see above).
- [x] I have read the [Contributing
Guide](https://github.com/quokka-astro/quokka/blob/development/CONTRIBUTING.md).
- [ ] I have added tests for any new physics that this PR adds to the
code.
- [ ] I have tested this PR on my local computer and all tests pass.
- [ ] I have manually triggered the GPU tests with the magic comment
`/azp run`.
- [x] I have requested a reviewer for this PR.
@ZedThree
Copy link
Owner

@BenWibking Apologies, missed that I hadn't made a new release, now available as v0.17.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix clang-tidy-review comment posting quokka-astro/quokka
2 participants
@ZedThree @BenWibking