Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bitflags from 1.3.2 to 2.0.0 #6326

Closed
mpguerra opened this issue Mar 15, 2023 · 5 comments
Closed

Bump bitflags from 1.3.2 to 2.0.0 #6326

mpguerra opened this issue Mar 15, 2023 · 5 comments
Assignees
Labels
C-enhancement Category: This is an improvement

Comments

@mpguerra
Copy link
Contributor

Motivation

This is a breaking dependency upgrade. See: #6305 (review)

Specifications

Complex Code or Requirements

Testing

Related Work

@mpguerra mpguerra added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Mar 15, 2023
@oxarbitrage
Copy link
Contributor

This upgrade has a bunch of problems: bitflags/bitflags#310

I tried to fix it in our end with some experiences other people are having but i was not able to make it work yet.

I am unsure if they will make a new minor update to fix some. Ill know more soon as i will investigate it further.

@oxarbitrage
Copy link
Contributor

I crated an issue in the bitflags repo. Lets see how it goes.

bitflags/bitflags#314

@oxarbitrage
Copy link
Contributor

bitflags bumped a new version 2.0.1 where they explain better what changes are needed.

I made the needed changes to support the upgrade in #6346

@mpguerra
Copy link
Contributor Author

@teor2345
Copy link
Contributor

Fixed by PR #6346.

@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is an improvement
Projects
Archived in project
Development

No branches or pull requests

3 participants